If I take a quick critical look at the UI of flood_unblock I notice a number issues (mainly wording) that could be improved:

"Use the table below to view the available flood entries"
"Seperate"
"Clear flood"
"Type of block"

CommentFileSizeAuthor
#17 streamline-ui-3159166-17.patch2.9 KBPooja Ganjage
#10 Implement_Streamline_UI_3159166.patch1.31 KBPooja Ganjage
#7 Implement_Updated_UI_Words_3159166.patch6.82 KBPooja Ganjage
#3 Implement_Streamline_UI_3159166.patch5.97 KBPooja Ganjage
#2 streamline-ui-3159166-1.patch3.2 KBbatigolix

Issue fork flood_unblock-3159166

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

batigolix created an issue. See original summary.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
StatusFileSize
new streamline-ui-3159166-1.patch3.2 KB

Changes in this patch:
- consistent module naming and description
- typo fixes
- shorter and (hopefully) clearer labels

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new Implement_Streamline_UI_3159166.patch5.97 KB

Hi,

I am applying patch for more improvement UI words.

I hope may be it helps to you.

Kindly review this patch once.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Needs review » Postponed

Your patch containes changes in the help text which I was planning to remove in #3159265: Replace hook_help by help_topics.
So lets pause this issue until that is solved,

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Postponed » Needs work

@Pooja Ganjage: #3159265: Replace hook_help by help_topics is fixed, so you can have another go at this issue.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new Implement_Updated_UI_Words_3159166.patch6.82 KB

Hi,

I am applying updated patch for this issue.

Review this patch once again.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
Status: Needs review » Needs work 
+++ b/modules/contrib/flood_unblock/src/Form/FloodUnblockAdminForm.php
@@ -95,19 +95,19 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+      '#value' => $this->t('Remove flood'),

Shouldn't we use the text "Removed selected items from the flood table"? Or something?

+++ b/modules/contrib/flood_unblock/src/FloodUnblockManager.php
@@ -104,7 +104,7 @@ public function getEntries() {
+            $user_link = $this->t('Deleted User: @user', ['@user' => $result->uid]);

User shouldn't be capitalized

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new Implement_Streamline_UI_3159166.patch1.31 KB

Hi,

Attached Updated patch.

Kindly review it once.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Needs review » Needs work

@Pooja Ganjage: when you created your patches you did not use my patch as a base.
As a result many of my changes from (#2) have been lost.

Can you start all over?
First apply my patch (#2) and than start adding your changes.

If you upload a new patch then put the comment #number in the filename: e.g. streamline-ui-3159166-13.patch

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Assigned: Unassigned » batigolix

batigolix opened merge request !3

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Needs work » Needs review

@Pooja Ganjage: I went ahead a made the changes.

@fabianderijk: there is a merge request ready.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Assigned: batigolix » fabianderijk
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new streamline-ui-3159166-17.patch2.9 KB

Hi,

Attached updated patch.

Kindly review it once.

Thanks.

  • batigolix committed f01eca9 on 3.0.x 
    Issue #3159166 by Pooja Ganjage, batigolix, fabianderijk: Streamline UI

  • fabianderijk committed 709fa05 on 3.0.x 
    Issue #3159166 by Pooja Ganjage, batigolix, fabianderijk: Streamline UI
fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
Status: Needs review » Fixed

This is now marked as fixed. Thanks you all!

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented

Grate!

Pooja Ganjage’s picture

Pooja Ganjage commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.