Originally reported nearly six years ago at #2343213: SQLBase::mapjoinable does not support SQLite, the solution that was introduced there was incomplete.

That only covered the case of a SQLite source DB and a non-SQLite destination DB.

The inverse is still not supported.

CommentFileSizeAuthor
#2 3159101-2.patch829 byteswim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3159101-2.patch829 bytes
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs review » Reviewed & tested by the community

I would normally ask for a test, but a practical test would be difficult, and a unit test would just end up testing the obvious logic there, so it's not as helpful.

  • larowlan committed fc78db5 on 9.1.x 
    Issue #3159101 by Wim Leers: SQLBase::mapjoinable still does not support...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Title: SQLBase::mapjoinable still does not support SQLite » [backport] SQLBase::mapjoinable still does not support SQLite

Agree

Committed fc78db5 and pushed to 9.1.x. Thanks!

Re-titling for backport after freeze is over

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Bug Smash Initiative

Agree

Committed fc78db5 and pushed to 9.1.x. Thanks!

for backport after freeze is over

  • larowlan committed ec1f6a9 on 9.0.x 
    Issue #3159101 by Wim Leers: SQLBase::mapjoinable still does not support...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 9.0.x-dev » 8.9.x-dev

Backported to 9.0.x, waiting on test run for 8.9.x

  • larowlan committed 63971d5 on 8.9.x 
    Issue #3159101 by Wim Leers: SQLBase::mapjoinable still does not support...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Title: [backport] SQLBase::mapjoinable still does not support SQLite » SQLBase::mapjoinable still does not support SQLite
Status: Reviewed & tested by the community » Fixed

c/p to 8.9.x because the risk of disruption is low

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.