The 'Advanced' section of fields includes two field descriptions with links to Wikipedia ('geo_position' and 'icbm'). The text of both links is the same ('see Wikipedia for details') while the URLs are different, which is bad for accessibility.

An easy fix would be to change the link text to something like 'see Wikipedia for details on Geographic coordinate system'

If the relative brevity of the visible link text is valuable, make that more complete & unique text into an aria-label attribute on the link.

Thanks!

CommentFileSizeAuthor
#2 unique_link-3158395-2.patch1.78 KBkasey_mk

Comments

Kasey_MK created an issue. See original summary.

kasey_mk’s picture

kasey_mk commented
StatusFileSize
new unique_link-3158395-2.patch1.78 KB
geekygnr’s picture

geekygnr commented
Status: Active » Needs review

Looks like the patch as the solution so moving to Needs Review.

geekygnr’s picture

geekygnr commented
Status: Needs review » Reviewed & tested by the community

Looks good.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Is there a rationale to use "aria-label" instead of "title"?

geekygnr’s picture

geekygnr commented

I didn't write it but it looks like it follows WCAG guidelines: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA8.html

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue tags: +Accessibility

Is there a rationale to use "aria-label" instead of "title"?

Yeah, the title attribute is considered bad practice now.

See #3083583: [META] Discourage non-inclusive use of the HTML title attribute for a bit of background. This issue was created by @andrewmacpherson who is a Drupal accessibility maintainer.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3083583: [META] Discourage non-inclusive use of the HTML title attribute

I didn't know about that, thanks for the insights!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

We can do a separate issue for updating the codebase(s).

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Avoid similar-sounding links with different purposes » Avoid similar-sounding links with different purposes (D8)
Status: Reviewed & tested by the community » Fixed
Parent issue: » #3203686: Plan for Metatag 8.x-1.17

Committed. Thank you.

I'll do a separate issue to backport the change to D7.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.