Related: #3145797: [META] Make Drupal 7 core compatible with PHP 8.0

PHP 8.0 issues deprecation notices when an optional parameter appears before the last required parameter of a function or a class method.

Adding preliminarily fixes to run in Drupal infra.

CommentFileSizeAuthor
#5 3156847-drupal7-php8-required-parameter-after-optional--2.patch5.73 KBayesh
#2 3156847-2.patch5.59 KBayesh
3145797-1-param-order.patch683 bytesayesh

Issue fork drupal-3156847

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ayesh created an issue. See original summary.

ayesh’s picture

ayesh commented
StatusFileSize
new 3156847-2.patch5.59 KB
ayesh’s picture

ayesh commented
Parent issue: » #3145797: [META] Make Drupal 7 core compatible with PHP 8.0
sjerdo’s picture

sjerdo
Primary language Dutch
Location Haarlem
commented

We shouldn't just make all subsequent parameters optional
Eg for SelectQuery, the parent class Query requires the $connection parameter, which was made optional in patch #2
https://3v4l.org/A3j9G

+++ b/includes/database/select.inc
@@ -964,7 +964,7 @@ class SelectQuery extends Query implements SelectQueryInterface {
+  public function __construct($table, $alias = NULL, DatabaseConnection $connection = NULL, $options = array()) {

We should change this so $alias is required too (but allow null). Parameter $connection is required by the parent class.

See https://3v4l.org/A3j9G

ayesh’s picture

ayesh commented
StatusFileSize
new 3156847-drupal7-php8-required-parameter-after-optional--2.patch5.73 KB

You are right, thanks @sjerdo.
I updated the patch with that method now making `$alias` parameter a required one.

Taran2L made their first commit to this issue’s fork.

Taran2L opened merge request !362

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented

hi @Ayesh, I've made a few changes and opened an MR. Please review.

In general, I think optional params can safely be made required because when the corresponding code is being called they are always set anyway with a few exceptions. Please see my comments in MR

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Active » Needs review
fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

Setting to RTBC

mcdruid made their first commit to this issue’s fork.

  • mcdruid committed f5a0ff9 on 7.x 
    Issue #3156847 by Ayesh, Taran2L, sjerdo: [PHP 8] Parameter order fixes
mcdruid’s picture

mcdruid commented
Status: Reviewed & tested by the community » Fixed

Thank you!

mcdruid closed merge request !362

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

poker10 credited apaderno.

poker10 credited Liam Morland.

poker10’s picture

poker10 commented

Added credits from the duplicate issue #3018815: Optional parameters must be at end of argument list.