Address @todo in claro_preprocess_fieldset__media_library_widget

Addressed the todo. Here is the patch.

+++ b/core/themes/seven/seven.theme
@@ -321,21 +321,6 @@ function seven_preprocess_media_library_item__small(array &$variables) {
- * @todo Remove this when https://www.drupal.org/project/drupal/issues/2999549

@himanshu thanks for the patch. The reference issue given in the file is fixed now.

@todo is taken in consideration.

Looks good now.

Changing status to RTBC.

Thanks for the clarification @laurii, did the same in this patch.

Resolved tests.

This should resolve the failed test cases from #13

Adding a parent

Patch needs rerolling.

+++ b/core/modules/media_library/src/Plugin/Field/FieldWidget/MediaLibraryWidget.php
@@ -84,12 +92,15 @@ class MediaLibraryWidget extends WidgetBase implements TrustedCallbackInterface
+    $this->linkGenerator = $link_generator;

We can't just add this here, we have to provide backward compatibility and a deprecation in case someone extended this class. We can't add new deprecations in 9.5.x or 10.0.x so this has to go to 10.1.x now.

Reroll the patch #17 with Drupal 9.5.x

Thanks @Ankit.Gupta, but you've might have missed this comment:

We can't just add this here, we have to provide backward compatibility and a deprecation in case someone extended this class. We can't add new deprecations in 9.5.x or 10.0.x so this has to go to 10.1.x now.

So the reroll has to be against 10.1.x-dev,, not 9.5.x-dev.

Re-roll given against 10.1.x, Please have a look.

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Please include an interdiff with your patch

We can't just add this here, we have to provide backward compatibility and a deprecation in case someone extended this class. We can't add new deprecations in 9.5.x or 10.0.x so this has to go to 10.1.x now.

has not been addressed

Tagging for change record also for the new paramter

Retitling the issue given that Seven has been removed, but Claro has the same code.

Removing Seven tag and self-assigning

Updated IS

Added draft CR and switched to MR-workflow.

Thank you @Spokje for adding the trigger_error.

Reviewing the MR code everything looks clean
Deprecation has been added
Deprecation is being tested
New functions have correct typehints

Ran the test locally without the fix and got

Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 @expectedDeprecation:
-%A  Calling Drupal\media_library\Plugin\Field\FieldWidget\MediaLibraryWidget::__construct without

Verified that the claro media library widget works fine.

Great job!

Tested manually in Claro and spotted some regressions

• "Show media item weights" button is not styled and is mising the following classes
  .action-link action-link--extrasmall .action-link--icon-show .media-library-widget__toggle-weight
• "Add Media" button is missing the .media-library-open-button class. This one I'm unsure if the class is used anywhere, but even if Claro is internal this should probably be preserved unless there's a compelling reason to get rid of it.

This is the plain diff from the 10.1.x: https://git.drupalcode.org/project/drupal/-/merge_requests/3323.diff

Using that on top of a new MR, based on 11.x.

(Rebasing an MR from 10.something.x to 11.x is a nightmare, at least to me, and there where no threads, not even closed on the 10.1.x MR.)

This needs to be re-rolled for Drupal 10.3.6

This is rooted in a SIX+ year old issue, that just needs to have 10 lines of code removed that impacts some classes on a base theme...

Can we get this closed out?