Problem

 - 1 error(s) identified by config_inspector to fix :
  ------------------------------------------------------------- ---------------- 
   Key                                                           Status          
  ------------------------------------------------------------- ---------------- 
   core.entity_view_display.node.news.full:third_party_setting   missing schema  
   s.layout_builder.sections.0.components.671f83eb-7f5c-48c2-b                   
   583-82e63dd30c7a.configuration.path                                           
   core.entity_view_display.node.news.full:third_party_setting   missing schema  
   s.layout_builder.sections.0.components.671f83eb-7f5c-48c2-b                   
   583-82e63dd30c7a.configuration.external_path                                  
   core.entity_view_display.node.news.full:third_party_setting   missing schema  
   s.layout_builder.sections.0.components.671f83eb-7f5c-48c2-b                   
   583-82e63dd30c7a.configuration.sharethis_path                                 
   core.entity_view_display.node.news.full:third_party_setting   missing schema  
   s.layout_builder.sections.0.components.671f83eb-7f5c-48c2-b                   
   583-82e63dd30c7a.configuration.sharethis_path_external                        
  ------------------------------------------------------------- ---------------- 
 Configuration is not valid

Proposed resolution

Add missed config schema. Fix the "defaultConfiguration" definition.

CommentFileSizeAuthor
#2 sharethis-add_missed_widget_block_schema-3156417-2.patch1.11 KBoleksiy

Comments

Oleksiy created an issue. See original summary.

oleksiy’s picture

oleksiy
Primary language Ukrainian
Location Lutsk 🇺🇦
commented
Status: Active » Needs review
StatusFileSize
new sharethis-add_missed_widget_block_schema-3156417-2.patch1.11 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented

Any reason to prefix settings with module name when block is module defined?
Otherwise rtbc, but would be great to cover with tests

vacho’s picture

vacho commented

The prefix is because the form (sharethis/src/Plugin/Block/SharethisWidgetBlock.php) saves the settings as "sharethis_path" and "sharethis_path_external" respectively. So is right that the names of the configuration will be identical.

vacho’s picture

vacho commented
Status: Needs review » Reviewed & tested by the community

The patch fixes well the config schemas issues. I tested at local.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Committed! Thank you for your contributions! 🍹

  • VladimirAus committed 6d68b48a on 8.x-2.x authored by Oleksiy 
    Issue #3156417 by Oleksiy, vacho, andypost, VladimirAus: Missed schema...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.