Odd an option to the IEF configuration to enable or disable the popup

CommentFileSizeAuthor
#2 ief widget.jpg99.76 KBDrupalengue

Issue fork ief_popup-3155900

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dwkitchen created an issue. See original summary.

Drupalengue’s picture

StatusFileSize
new99.76 KB

I agree with @dwkitchen: it would be great if we could configure when dialog is enabled and also if it should work automatically or not. With nested IEF I would suggest to disabled the automatic behaviour after the 1st IEF by default and maybe even not available from 2nd level nested IEF and deeper IEFs.

Automatic behaviour makes nested IEF almost unusable or at least counterintuitive, because the last nested child is the first one to be presented to the user automatically and also doesn't have a cancel option. So for example, a referenced product with multiple variations shows first the dialog to add a variation and only after adding one, the parent product form is shown. After adding one variation you can add another one by clicking the "Add new variation" button, which opens the form on a dialog, as expected.

IMO, the automatic option works only for first level IEF, but the popup dialog can be useful on child IEFs. I would add a radio button on the IEF widget (image attached) to disable the popup when it is not wanted and disable the automatic behaviour after the first level of nested IEF.

The only other module I see to get a similar functionality is entity browser but it adds extra complexity when only a popup is needed for IEFs. Thanks for your work on the module @dataweb and I hope the automatic functionality can be disabled so this module becomes useful for many more use cases.

GuillaumePacilly made their first commit to this issue’s fork.

guillaumepacilly’s picture

@Drupalengue I added a MR with a possible approach. It gives the opportunity to activate or not the popup features for each ief widget.

guillaumepacilly’s picture

Version: 8.x-1.x-dev » 2.1.1
dataweb’s picture

Works like a charm @GuillaumePacilly. Good job!

dataweb’s picture

Version: 2.1.1 » 2.2.0
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bramdriesen’s picture

Title: Make Configurable » Make modal popup configurable

I highly suggest to work with merge requests and the correct merge commit messages. Makes it way easier to track back commits to an issue.