In D8 the Devel Debug function dd() has become ddm() due to a name conflict with 3rd-party software. This needs to be added to DiscouragedFunctionsSniff

CommentFileSizeAuthor
#2 3155865-2.ddm-in-discouraged-list.patch691 bytesjonathan1055

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review
StatusFileSize
new 3155865-2.ddm-in-discouraged-list.patch691 bytes

Patch attached. I will add test coverage and create a PR if you agree that this function shiuld be covered.

jonathan1055’s picture

jonathan1055 commented
Parent issue: #3129344: Include ddbug_backtrace and other devel functions in discouraged/forbidden functions »

PR 113
https://github.com/pfrenssen/coder/pull/113

arkener’s picture

arkener commented
Status: Needs review » Needs work

That makes sense. I've added a comment with a request for a very minor change on the PR.

jonathan1055’s picture

jonathan1055 commented
Status: Needs work » Needs review

PR updated.

  • jonathan1055 authored 792cc9e on 8.x-3.x 
    feat(DiscouragedFunctions): Include ddm() devel function (#3155865 by...
arkener’s picture

arkener commented
Status: Needs review » Fixed

Thank you for this patch!, the PR has been merged.

jonathan1055’s picture

jonathan1055 commented

Thanks. Just wondering about your workflow. Once the PR is merged, do you then push to drupal.org? Or do you also use the patch provided in this issue to apply locally and then push to d.o.? I presume it is the former, and in which case do you still like to see patches here in the d.o. issue queue? They are not tested here, so it could save effort if they are not required.

jonathan1055’s picture

jonathan1055 commented

Or maybe other devs want to test out the patch but they do not use github, and want to patch their own Coder code locally & manually. In which case patches are required here.

arkener’s picture

arkener commented

We currently pull the GitHub branch after the PR is merged and push the updated branch to drupal.org. We currently don't really require patches in the d.o. issue as most of the changes will be checked via the PR, so feel free to skip them :). If developers want to help testing without pulling the GitHub repository then they can retrieve the patch for latest version of the PR by appending ".patch" to the PR url, for example https://github.com/pfrenssen/coder/pull/113.patch. Though it might be a good idea to include this url in the issue, so other developers know where to get the patch.

jonathan1055’s picture

jonathan1055 commented

OK. That's good, yes I will mention adding .patch whenever I post a PR here. I think it would be worth adding point 4 to "Contributing" on the Coder project page:

4. Patches are not required on drupal.org. In the issue post a link to the PR url with ".patch" added to enable developers to directly retrieve an aggregated patch for all the changes in the PR

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.