There are component that exists in rain_theme and in collective_theme.
The collective_theme uses the rain_theme as a parent theme, so we should be able to integrate these components from Rain to prevent duplicated components & code within collective_theme.

  • Look at the templates, example: mis_collective/web/profiles/contrib/collective/themes/collective_theme/src/templates/paragraphs/paragraph--text.html.twig
  • We would still like to demo the component in the Pattern Lab style guide. So do something like this in Pattern Lab for example:
    • Update the component in collective_theme to extend from Rain in the twig file. (Example) Maybe commenting that would be good.
    • Update the stylesheet to ONLY have overrides specific for collective_theme, should really just be colors and perhaps spacing. (Example again) - comments here would be great too. For example ‘style overrides only for rain_theme/component - see full styles in rain_theme’ (or similar)
      • If it turns out you need to refactor markup - let’s pause and look at the component in rain_theme and see if we can make it flexible to support both, without causing regressions in Rain.
    • You can create a json file for Pattern lab, so we can still see the component. in our collect_theme pattern lab/=. (Example)
    • Finally the last piece should be extending the libraries, so in Drupal we know we want to include the styles from rain_theme, and the style overrides we added to Pattern Lab. We can do this in collective_theme.info Example

The following components should be reviewed, and determine whether they should be re-integrated and removed from collective in favor of the rain_theme version:

- Body-Text
- Button
- Card
- Card List
- Carousel
- Eyebrow
- Heading
- Icons
- Event Date Tiles
- Event Date Time
- Event Teaser
- L-2x
- L-3x
- L-Flex
- Main Menu / Menu / Site-header
- Page Title
- Pager
- Search Box
- Site Branding
- Site Footer
- User Account Nav

Comments

madelinelise created an issue. See original summary.

madelinelise’s picture

Issue summary: View changes
madelinelise’s picture

Title: Integrate body-text component from rain_theme » Integrate duplicated components from rain_theme
Issue summary: View changes
madelinelise’s picture

Issue summary: View changes
madelinelise’s picture

Issue summary: View changes