Attached patch allows for the title to be displayed. Since 'item_list' already has a "title", we can provide it via the settings from the facet UI

CommentFileSizeAuthor
#8 facet-title-patch-result.png3.36 KBruturaj chaubey
#8 facet-settings-form-result.png27.1 KBruturaj chaubey
#7 Screenshot from 2022-03-21 12-38-49.png24.04 KBlibbna
#6 space-in-if-stmt-3154429-6.patch1.07 KBlibbna
#2 3154429-1-show-facet-title.patch646 bytesdrcolossos

Issue fork search_api_glossary-3154429

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DrColossos created an issue. See original summary.

drcolossos’s picture

drcolossos commented
Status: Active » Needs review
StatusFileSize
new 3154429-1-show-facet-title.patch646 bytes
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Needs work
Issue tags: +Needs manual testing, +Needs steps to reproduce, +Novice

Thanks for the issue and patch!

I'm working on creating a Drupal 9 release and am reviewing all "needs review" issues in the process.

Confirmed that the patch still applies cleanly and modifies:

src/Plugin/facets/widget/GlossaryAZWidget.php

as expected.

+++ b/src/Plugin/facets/widget/GlossaryAZWidget.php
@@ -43,6 +43,10 @@ class GlossaryAZWidget extends WidgetPluginBase implements WidgetPluginInterface
+    if($facet->get('show_title') === TRUE) {

Nitpick: Add space after the "if".

It would also be good to have steps for testing. Thanks!

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Needs screenshots

And screenshots :)

libbna’s picture

libbna commented
Assigned: Unassigned » libbna
libbna’s picture

libbna commented
Assigned: libbna » Unassigned
StatusFileSize
new space-in-if-stmt-3154429-6.patch1.07 KB

Added a space after if.

Steps for testing:

  • Cloned the repo - git clone --branch '8.x-4.x' https://git.drupalcode.org/project/search_api_glossary.git
  • cd search_api_glossary
  • downloaded the latest patch - wget 3154429-1-show-facet-title.patch
  • applied the patch - git apply path_of_the_patch_
  • added space after if
  • checked the drupal coding standards using phpcbf and phpcs commands.
  • and then created a patch git diff > space-in if-stmt-3154429-6.patch
libbna’s picture

libbna commented
Status: Needs work » Needs review
StatusFileSize
new Screenshot from 2022-03-21 12-38-49.png24.04 KB

Adding a screenshot.

ruturaj chaubey’s picture

ruturaj chaubey
He/Him
Primary language English
Location Pune, India
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new facet-settings-form-result.png27.1 KB
new facet-title-patch-result.png3.36 KB

The patch works fine.

laura.gates made their first commit to this issue’s fork.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: Unassigned » kristen pol
Issue tags: -Needs manual testing, -Needs steps to reproduce, -Needs screenshots

Thanks for updating the patch @Libbna. When I asked for testing steps, I meant testing the functionality works with the patch :)

Since @Ruturaj Chaubey has tested and provided screenshots (thanks!) and this is such a simple change, I'll try to get it in now.

  • Kristen Pol committed e824845b on 8.x-4.x authored by Libbna 
    Issue #3154429 by Libbna, DrColossos, Ruturaj Chaubey, Kristen Pol:...
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Reviewed & tested by the community » Fixed

This has been merged and will be part of this release: #3377587: Create 8.x-4.2 release.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » Unassigned
Status: Fixed » Closed (fixed)

Released: https://www.drupal.org/project/search_api_glossary/releases/8.x-4.2