June 29, 2020 - Meeting Agenda [#3153870]

Meeting Agenda

Introductions
Status
Issue updates and discussion
Where can people help this week?

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

Meeting Minutes

Hello, welcome to this week’s Front-end theme Olivero meeting!• This meeting happens every Monday at 2pm GMT (10am ET)• There is no audio or video -- this meeting is chat only• The conversations for this meeting happen in threads0️⃣ If you’re attending this meeting, please let us know here and leave a comment in the meeting agenda issue so we can give you issue credit on d.o.: #3153870: June 29, 2020 - Meeting Agenda

kiran.kadam911	Hello Everyone! :slightly_smiling_face:
KarinG	Good morning!
cocoabean	Morning/afternoon!
Indrajith KB	Hi all...!!!
Hansa	Hello everyone! :wave:
mherchel	I made it! Morning :slightly_smiling_face:
kishor_kolekar	hello :wave:
komal k	Hi..:wave:
Sreenivas Bttv	hello :wave:
rangaswini	Hi :slightly_smiling_face:
nitesh624	Hi
jyoti mishra	Hi, jyoti from india
ashishdalvi	Hello Everyone,I am a backend developer. So, I can contribute to any issue which required backend developer attention.
pooja	hello
shaal	Hello :wave:
yogeshmpawar	Hello Guys :wave:
Ruchi	Hello all
Shalini Gaur	Hello All
sd9121	Hey :wave:

1️⃣ Overall project status updateOur path to beta is currently headed towards Drupal 9.1. #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

mtift (he/him)	Let's use this issue to discuss the overall status of the initiative in broad terms, and we'll save specific issue discussions for later threads.
mherchel	image.png
mherchel	Lots of great work!
mherchel	I also met with our designers to get a plan for focus states, and that went well. I have the issue assigned to myself at the moment, and hope to work on it this week
mherchel	I also have a conversation with @nod_, who is a JavaScript maintainer for Drupal core. That went really well, with some minor changes requested
mherchel	I’m planning on meeting with @andrewmacpherson (who is an accessibility maintainer for Drupal core) this week, also, to go over any accessibility concerns with the primary nav
mherchel	And we are also going to do real world accessibility testing in late July with the National Federation for the Blind!
mherchel	But at this point we’re fairly feature complete, and will concentrate on 1) bugs, 2) accessibility, and 3) coding standards
mherchel	I hope to release alpha4 this week, which will be our final alpha. Once we do that, we’ll submit an updated core patch
mherchel	phew thats a lot
proeung	I also wanted to note that our designers (Jared and Jen) are working updating the Figma files to reflect the latest changes and figuring out a design pattern for the block styling and misc pages like (404 and 403 pages).
Indrajith KB	need maintenance page too..

2️⃣ Individual issue discussion

mtift (he/him)	This thread is the place to bring up specific issues that need some extra discussion
mherchel	We have a number of issues that are waiting for review or RTBC. I’m going to try do get to those in the next few days before releasing alpha4
mherchel	Other than that, i’m concentrated on focus styles and bugs
KarinG	Is there anything else I can do re: #3153334: All caps titles and Dyslexia
kiran.kadam911	Need some clarification on: #3153860: Theme and Configure the RSS Feed Views Block #comment-13724485
mherchel	@KarinG we’re waiting on designers for that. I met with them on Friday. We’re going to have to adjust each component so it keeps the visual hierarchy and still looks good before removing the uppercase
mherchel	@kiran.kadam911 i will take a look
KarinG	@mherchel - Got it. We got that feedback from a client [live accessibility testing so to speak]
mherchel	good to know! Was that recorded? I’d love to see it
pooja	Please Review this #3152382: Radios and checkbox not aligned with label in settings tray
KarinG	One of our devs just referenced a general doc on all-caps is bad for those with dyslexia [in that issue]
pooja	#3151586: Remove bullet of link action Please review this.
mherchel	@pooja note that I have a list of issues that are tagged with “needs review” I’ll be getting to them this week hopefully!
yogeshmpawar	@mherchel - when we are targeting this META issue - #3124796: META: Adjust Olivero codebase to meet Drupal coding standards
KarinG	@mherchel - and further thoughts on #3145934: Enable the usage of social media icons on Olivero's left "social bar" - It's by no means critical (or even important) - but would add to the cool factor.
mherchel	@yogeshmpawar really as soon as we can get to it. It’s probably the lowest of the main priorities right now, but still important!
Indrajith KB	Hi, We have one old ticket, but need some attention (not that much priority)#3130243: Olivero's default input element background color doesn't differentiate between disabled color
mherchel	@KarinG it looks like we are going to be able to place the RSS feed there (there’s a core “syndicate” block!). As far as actual social media icons, they’d be actual links not “share buttons”. We’d have to do that in the theme settings… I’d like to talk to some core committers about it first.
KarinG	Cool! :slightly_smiling_face:
himanshu_sindhwani	#3124796: META: Adjust Olivero codebase to meet Drupal coding standards
himanshu_sindhwani	@yogeshmpawar I created and fixed the child for this

3️⃣ Where can people help this week?

mtift (he/him)	Add your suggestions here
Indrajith KB	Right now we have plenty of devs so please try to don't keep an issue assigned(except maintainers) more than three days. (edited)
mherchel	There’s a number of older issues that’d be nice to test to see if they’re still happening
mherchel	Other than that, i’d love to see the theme on more real world sites with real world content. it’ll surface visual inconsistencies
mherchel	and help finding bugs is always great :smile:
nitesh624	I can pick some needs review issues in coming days
KarinG	@mherchel -> here's a real world site:
mherchel	I don’t see the URL yet
KarinG	image.png
KarinG	subtheme: added top region for jumbotron and did colours - that's it
mherchel	Nice! How did you change the colors? Just override with your own CSS?
KarinG	Yes
mherchel	cool. At some point in the future, we’d love to make that a configurable option
KarinG	It took some time to hunt down all the classes (esp that triangle!) but found them all
mherchel	lol
mherchel	Do you think we need a separate region for the “Jumbotron”?
mherchel	that looks good there
KarinG	image.png
KarinG	See all pink!
mherchel	:smile:
mherchel	yeah, i also need to abstract out the CSS variable colors
mherchel	I should make myself an issue for that
KarinG	Not trying to give you more work!
mherchel	yeah i know :stuck_out_tongue:
KarinG	Only issue we ran into was that the Read more links had been stripped - but you clarified that's a design choice. So we are also overriding node--teaser.html.twig
KarinG	@mherchel - PS - if you think you want a top/jumbotron region happy to open an issue/PR that. It's pretty simple and very effective
mherchel	yeah, do so! I already forwarded the link to the designers!

Participants:

kiran.kadam911, KarinG, cocoabean, Indrajith KB, Hansa, mherchel, kishor_kolekar, komal k, Sreenivas Bttv, rangaswini, nitesh624, jyoti mishra, ashishdalvi, pooja, shaal, yogeshmpawar, Ruchi, Shalini Gaur, sd9121, mtift (he/him), proeung, himanshu_sindhwani