Closed (fixed)
Project:
Drupal core
Version:
10.2.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Jun 2020 at 05:43 UTC
Updated:
15 Mar 2024 at 11:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hardik_patel_12 commentedKindly follow a new patch.
Comment #3
nitvirus commentedAssignign this to myself
Comment #4
nitvirus commentedOn applying patch, I am getting error:
error: corrupt patch at line 10When adding a new line it seems to work. Seems there is
' No newline at end of file' error.
Comment #5
nitvirus commentedadding a patch with a new line character at end.
Comment #6
naresh_bavaskarThe above patch #2 looks good to me and applied successfully.
@nitvirus #2 and #5 looks identical
Comment #7
xjmThanks everyone for working on this issue.
Just a note: the automated testing infrastructure tells us whether the patch applies, so we do not need people to review that. It is also not sufficient criteria for the issue to be marked "Reviewed and Tested by the Community".
What we do need people to review is whether the issue has a correct scope, whether it passes the core gates, whether the solution completely fixes the problem without introducing other problems, and whether it's the best solution we can come up with. See the patch review guide for more information.
Back to the issue at hand... I'm concerned that this link would have to be updated every minor. Can we get a link that is not minor-version-specific? Thanks!
Comment #8
nitvirus commentedGot it ,thanks for info @xjm
I have updated the patch with 9.0 link as per suggestion.
Thanks Again.
Comment #9
naresh_bavaskar@xjm Got it, Thanks for the info.
I think #8 still refers to a minor specific version and ideally, it has to update on every release.
Comment #10
nitvirus commented@naresh, there is no branch like 9.x to denote the major release, i believe we can keep 9.0.x as major version as there is no major change in scaffold files after that.
I may be wrong but if there is no change in files for 9.0.x branch and 9.1.x branch, I think updating links on release would be redundant task.
Comment #11
hardik_patel_12 commented@nitvirus , @naresh_bavaskar thanks for your efforts. @xjm i have checked there is no major-version link is there so we have to replace with some minor version for now.
Comment #12
siddhant.bhosale commentedComment #13
siddhant.bhosale commentedThe above patch #8 looks good to be merged.
Changing the status to RTBC.
Comment #15
hardik_patel_12 commentedRandom test case is failed , setting back to RTBC.
Comment #17
adsyy commentedHi, error seems not to be related to the current patch, how can we make this issue go to next step ? (i'm a noob trying to understand issue process step by step!)
Comment #18
alexpottThis link will always go out of date. This the one place we're putting a git.drupalcode.org link in documentation that's meant to be read and helpful. I think we need to consider a bit more careful how we do this.
I'm not sure what the right answer is here.
Comment #25
quietone commentedComment #27
quietone commentedComment #28
quietone commentedComment #29
smustgrave commentedSolution by MR from @quietone seems to address the concern #18 mentions.
Hiding patches for clarity.
Comment #30
quietone commentedI'm triaging RTBC issues.
Ah, this is one where I made the MR. The IS had duplicate sections, I have removed those.
Leaving at RTBC;
Comment #34
catchCommitted/pushed to 11.x, cherry-picked to 10.3.x and 10.2.x, thanks!