Problem/Motivation

The scaffolding documentation link in README.txt refers to version Drupal 8.

see
https://git.drupalcode.org/project/drupal/tree/8.8.x/composer/Plugin/Sca...

Steps to reproduce

Proposed resolution

Link to d.o docs so the link does not need to be regularly updated

https://www.drupal.org/docs/develop/using-composer/using-drupals-compose...

Remaining tasks

Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3153723

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Hardik_Patel_12 created an issue. See original summary.

hardik_patel_12’s picture

Assigned: hardik_patel_12 » Unassigned
Status: Active » Needs review
Issue tags: +Novice
StatusFileSize
new677 bytes

Kindly follow a new patch.

nitvirus’s picture

Assigned: Unassigned » nitvirus

Assignign this to myself

nitvirus’s picture

On applying patch, I am getting error:
error: corrupt patch at line 10

When adding a new line it seems to work. Seems there is
' No newline at end of file' error.

nitvirus’s picture

Assigned: nitvirus » Unassigned
StatusFileSize
new677 bytes

adding a patch with a new line character at end.

naresh_bavaskar’s picture

Status: Needs review » Reviewed & tested by the community

The above patch #2 looks good to me and applied successfully.
@nitvirus #2 and #5 looks identical

xjm’s picture

Status: Reviewed & tested by the community » Needs review

Thanks everyone for working on this issue.

Just a note: the automated testing infrastructure tells us whether the patch applies, so we do not need people to review that. It is also not sufficient criteria for the issue to be marked "Reviewed and Tested by the Community".

What we do need people to review is whether the issue has a correct scope, whether it passes the core gates, whether the solution completely fixes the problem without introducing other problems, and whether it's the best solution we can come up with. See the patch review guide for more information.

Back to the issue at hand... I'm concerned that this link would have to be updated every minor. Can we get a link that is not minor-version-specific? Thanks!

nitvirus’s picture

StatusFileSize
new677 bytes
new312 bytes

Got it ,thanks for info @xjm
I have updated the patch with 9.0 link as per suggestion.

Thanks Again.

naresh_bavaskar’s picture

@xjm Got it, Thanks for the info.
I think #8 still refers to a minor specific version and ideally, it has to update on every release.

nitvirus’s picture

@naresh, there is no branch like 9.x to denote the major release, i believe we can keep 9.0.x as major version as there is no major change in scaffold files after that.

I may be wrong but if there is no change in files for 9.0.x branch and 9.1.x branch, I think updating links on release would be redundant task.

hardik_patel_12’s picture

@nitvirus , @naresh_bavaskar thanks for your efforts. @xjm i have checked there is no major-version link is there so we have to replace with some minor version for now.

siddhant.bhosale’s picture

Assigned: Unassigned » siddhant.bhosale
siddhant.bhosale’s picture

Assigned: siddhant.bhosale » Unassigned
Status: Needs review » Reviewed & tested by the community

The above patch #8 looks good to be merged.
Changing the status to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: 3153723-8.patch, failed testing. View results

hardik_patel_12’s picture

Status: Needs work » Reviewed & tested by the community

Random test case is failed , setting back to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: 3153723-8.patch, failed testing. View results

adsyy’s picture

Status: Needs work » Reviewed & tested by the community

Hi, error seems not to be related to the current patch, how can we make this issue go to next step ? (i'm a noob trying to understand issue process step by step!)

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice
+++ b/composer/Template/README.txt
@@ -63,4 +63,4 @@ These template projects use drupal/core-composer-scaffold to place the scaffold
-https://git.drupalcode.org/project/drupal/tree/8.8.x/composer/Plugin/Scaffold

This link will always go out of date. This the one place we're putting a git.drupalcode.org link in documentation that's meant to be read and helpful. I think we need to consider a bit more careful how we do this.

I'm not sure what the right answer is here.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone’s picture

Title: Change the scaffolding documentation link in README.txt for Drupal 9 » Change the scaffolding documentation link in README.txt
Issue summary: View changes
quietone’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Solution by MR from @quietone seems to address the concern #18 mentions.

Hiding patches for clarity.

quietone’s picture

Issue summary: View changes

I'm triaging RTBC issues.

Ah, this is one where I made the MR. The IS had duplicate sections, I have removed those.

Leaving at RTBC;

  • catch committed 6a44971c on 10.2.x
    Issue #3153723 by quietone, Hardik_Patel_12: Change the scaffolding...

  • catch committed a29a34a8 on 10.3.x
    Issue #3153723 by quietone, Hardik_Patel_12: Change the scaffolding...

  • catch committed 6f8fa857 on 11.x
    Issue #3153723 by quietone, Hardik_Patel_12: Change the scaffolding...
catch’s picture

Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, cherry-picked to 10.3.x and 10.2.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.