[PHP 7.4.3] Trying to access array offset on value of type null in advagg_get_css_aggregate_contents()

So a few lines above, the code checks if (empty($info_on_files[$cid]['content_hash']))

Since this line isn't throwing any error, I am assuming we could use this same test to see if $info_on_files[$cid]['content_hash'] is null before doing the test on line 872 that is throwing the Notice if ($info_on_files[$cid]['content_hash'] !== $file_contents_hash)

Since something that is null is not going to equal the hash of a file. We can probably change the test to be if empty() or the original test.

Thoughts?

Here is my attempt at a patch.

This also fixes another PHP 7.4 issue that I was having.

I think my patch was not in utf8 so that's why it couldn't apply?

hi @kavin Morse
Please let me know if need then i will look on it

Modify @kevin patch with 7.x-2.x-dev branch code and add some coding standard format.

Hi Rishabh,

Thanks for fixing my patch. I have queued up an additional test using PHP 7.4 and MySQL 5.7 since this patch is meant to address a PHP 7.4 issue.

I have been using this patch in production for a few weeks now with no issue.

Would be great if someone else could also test it.

The patch #9 works for me.

Thanks @all!