The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
The test class in core/modules/node/tests/src/Functional/NodeRevisionsTest.php uses a regular database query instead of using an entity query.
Proposed resolution
Replace the regular database query with an entity query.
Remaining tasks
TBD
User interface changes
None
API changes
None
Data model changes
None
Release notes snippet
TBD
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 3151975-11.patch | 1.3 KB | daffie |
| #11 | interdiff_3-11.txt | 552 bytes | narendra.rajwar27 |
Comments
Comment #2
daffie commentedPatch changes the db queries to the same entity query.
Comment #3
daffie commentedForgot to add the
allRevisions()part to the entity query.Comment #4
snehalgaikwad commentedComment #5
snehalgaikwad commentedTested on local. Patch looks good to me.
Comment #6
pratik_kambleComment #7
pratik_kambleComment #9
daffie commentedBack to RTBC.
Comment #11
narendra.rajwar27patch missing
->accessCheck(FALSE).Updating the patch.
Comment #12
sajid_007 commentedComment #13
daffie commentedReuploading the patch from comment #11, because that is the one that should be committed.
The code change looks good to me.
For me it is back to RTBC.
@sajid_007: I do not see any differences between my patch from comment #3 and your patch, with the exception of the removed empty line. Could you add an interdiff.txt with your patch. In that way the person who reviews your patch can easily see what changes you made.
Comment #14
alexpottAs #12 was added without explanation or interdiff I'm removing issue credit as this patch is not part of the final patch.
Committed and pushed 702e824664 to 9.1.x and f6a64b3e81 to 9.0.x and 884d2a50fe to 8.9.x. Thanks!
Backported to 8.9.x to keep the tests aligned.