Problem/Motivation

Content rendered in Full may be previewed by clicking the 'Preview' button. However this does not appear to properly render a Flag on the Full content type.

Steps to recreated:

  • Create a flag type.
  • Add the flag type to the default or 'Full' content display.
  • Add a node on the node add page for a node that has 'Preview' enabled.
  • Click 'Preview'.
CommentFileSizeAuthor
#2 3151909_2.patch2.5 KBnejcramsak

Issue fork flag-3151909

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

brooke_heaton created an issue. See original summary.

nejcramsak’s picture

nejcramsak commented
StatusFileSize
new 3151909_2.patch2.5 KB

Hi, i created a patch for this, the flag appears on preview but doesn't have any functionality as the entity is not yet saved and cannot be flagged.

brooke_heaton’s picture

brooke_heaton commented

@nejcramsak Sorry to use this issue to ask, but do you have any insight as to why an Entity Reference to a node does not appear in preview?

tr’s picture

tr commented
Status: Active » Needs review

@nejcramsak: When you post a patch you need to set the issue status to "Needs review" so that the testbot will run tests on your patch.

This issue should also have a test case to demonstrate the problem and prove the patch fixes it.

ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Needs work
Issue tags: +Needs tests, +Needs reroll

mrinalini9 made their first commit to this issue’s fork.

mrinalini9 opened merge request !150

jaydev bhatt made their first commit to this issue’s fork.

deaom made their first commit to this issue’s fork.

deaom opened merge request !176

deaom’s picture

deaom commented
Version: 8.x-4.x-dev » 5.x-dev

To many test issues to resolve on the 8x branch that were probably already resolved in 5x, so cherry picked the commit from 8.x to 5.x and opened a new MR. The existing tests are passing. Still needs a test to showcase the change is working, so leaving status as is.

deaom’s picture

deaom commented
Status: Needs work » Needs review

Added a simple test that verifies that the flag link is visible on the preview page. Ready for review.

ivnish closed merge request !150

ivnish’s picture

ivnish
he/him
commented
Issue tags: -Needs tests, -Needs reroll

  • ivnish committed 7a114498 on 5.x authored by deaom 
    fix: #3151909 Flag does not render in node Preview

By: brooke_heaton
By...
ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.