Currently the webform condition comes with missing context and it throws MissingValueContextException So, all the remaining condition checks does not work.

CommentFileSizeAuthor
#8 image(3).png184.67 KBnginex
#7 condition-3151629-7.patch585 bytessmitghelani
#2 condition-3151629-2.patch3.43 KBrakshith.thotada

Comments

rakshith.thotada created an issue. See original summary.

rakshith.thotada’s picture

rakshith.thotada commented
StatusFileSize
new condition-3151629-2.patch3.43 KB
rakshith.thotada’s picture

rakshith.thotada commented
Status: Active » Needs review
solotandem’s picture

solotandem commented
Category: Bug report » Support request
Status: Needs review » Active

There is a reason the code your patch un-comments was commented (as the text comment indicates).

Even if this issue pointed out a legitimate bug, your patch includes:

  • whitespace and other changes unrelated to the issue
  • adds spaghetti code (a special exception for webform_submission)

and would be rejected for such.

See also #3113799: Container insertion condition 'negate' value not converted to boolean when saving in form which is likely the real issue.

If you disagree, then you will need to provide more details (see bug reporting guidelines).

solotandem’s picture

solotandem commented
Assigned: rakshith.thotada » Unassigned
Status: Active » Closed (works as designed)

Change status for lack of follow-up.

shabana.navas’s picture

shabana.navas commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Closed (works as designed) » Active

I'm seeing this now on the latest 2.0 version. I'm continuously getting the `MissingValueContextException` exception for the Group and Webform modules even when not setting the condition at all for these modules. I had to downgrade to the 8.x version in order for this module to work.

smitghelani’s picture

smitghelani commented
StatusFileSize
new condition-3151629-7.patch585 bytes

Created patch for added condition to avoid missing value exception for web-form submission.

nginex’s picture

nginex commented
Assigned: Unassigned » nginex
Status: Active » Needs work
StatusFileSize
new image(3).png184.67 KB

This is something that can be reproduced.

Just save a google tag container entity and see there there are bunch of conditions saved to the config entity, but ideally it should save only configured conditions. Default (untouched) conditions should not be stored in the config. The issue is happening when calling $entity->getInsertionConditions() and there are checks for default (untouched) conditions.

There reason is quite clear (negate is saved in wrong format), the way how conditions are saved is not ok. I know how to fix it.

Does not match because of negate

nginex’s picture

nginex commented
Assigned: nginex » Unassigned
Status: Needs work » Closed (duplicate)

This seems is already fixed in #3357105: Condition plugins not evaluated properly when using Some Modules