Remove bullet of link action

Here is the fixed review the patch attached before after patch screen shot for the reference.

How can I test this out? Do I need to create a specific type of field or view?

@DuneBL created olivero.links.action.yml in Olivero theme root but nothing happens on the front-page(default Olivero front-page). Is anything I am missing or can you please let me know steps to re-produce it that will be helpful. Thanks!

In action-link.css file there is .action-links selector that I can not find in output or in templates.

Should there be block--local-actions-block.html.twig template in Olivero?

Currently Olivero uses core/modules/system/templates/menu-local-action.html.twig for local action.

Claro for example uses templates/block--local-actions-block.html.twig for block (where it ads its local action classes) and core/themes/classy/templates/navigation/menu-local-action.html.twig for list item.

If I add .action-links to list item then link action is displayed without bullet with patch#3.

Hello @komalkolekar @DuneB,

I didn't found Add content action link even after enabling olivero as admin theme. So I tested patch #3 on structure > blocks > place block and it's working fine for action links hopefully same will get applied for add content.

Before patch:

After patch:

Observation: One thing that I noticed in structure > blocks alignment of block labels, category, etc. are not proper it has to be like vertically center in my opinion. If it is the right observation then we need to create a separate issue to handle it because I am not aware if there is an existing issue that is there to handle it.

Feel free to add your opinion, Thanks!

This is close. A couple notes:

1) Let's use var(--sp) instead of 1em to keep vertical rhythm consistent
2) Unfortunately we'll need to load this in the main bundle. There doesn't appear to be a core library that we can extend.
3) I looked at Bartik's implementation. They're setting the LI element to inline block so the buttons align when there are multiple buttons. This patch doesn't do that... they stack vertical. Let's do that.

Taking this up.

@mherchel
- No idea about pt.2 from the last comment, can you pls provide brief info that will be helpful.
- About pt.3 will apply inline-block to li for desktop and for mobile it will be like a stack.

Thanks!

No action item on #2. I was just making a note.

Patch #3 does not work everywhere. I activated Olivero as admin theme and Primary admin actions block in sidebar still has bullets. If I copy 'block--local-actions-block.html.twig' from Seven then styling gets applied with patch provided.

Hello,

Kindly review the attached patch.

As per your comments, Handled both points as per @mherchel comment(pt1. margin set to 0 because cta button is already having margin) and created block--local-actions-block.html.twig for Primary admin actions block as per @vebrovski comment.

Thanks!

@kiran.kadam911 tested the patch. Worked for me. Please refer the SS

Before:

After:

Hi @kiran.kadam911 thanks for the patch, and i have some findings

1. Button letter color is black which should be the same color as other buttons (default state)
Attaching screenshot after patch-16:

Expected behaviour:

2. You have added the template (block--local-actions-block.html.twig) which is not affecting in the theme.

@Indrajith KB Please review the updated patch with fixes of obove issue. This line of code causing issue

.ui-widget-content a {
color: #333333/*{fcContent}*/;
}

Actual Issue:

Fixed Issue:

Hi @poojakural,
In your patch some changes are missing if you compare with #16 patch. Is it intended changes? Also please attach interdiff file.

Please review the updated patch with fixes of obove issue

Please ignore this above patch 3151586-24.patch

Last patch failed to apply. So I'm applying new patch against #16 . Fixing hover text color issue reported by @Indrajith KB. Please review it.

Hi @vebrovski nice finding, now the issue has fixed.

considering for the #15 and #27

for #15.

for #27

according to #12, 3rd point we no need to restrict the display:inline-block with media query. We need the display:inline-block for all width.

So please re-roll the patch according to the #12, 3rd point.

NB: Please avoid the patch #28 and interdiff .

Reviewed, but I'm a bit confused on what the "correct" colors on hover should be... Here are the results of my testing patch 27.
Regular:

Color: #0d77b5

Hover:

Color: #2494db

Focus:

Oops, I apologize. Looks like there was a new patch while I was reviewing...

Hi @ju.vanderw, it's okay actually i was trying to addressing the point from #12.
Here we have used the right color (i have confirmed with other buttons and design)

@Indrajith KB As per you obove comment. I have made changes accordingly. Please review the patch and interdiff.

according to #12, 3rd point we no need to restrict the display:inline-block with media query. We need the display:inline-block for all width.

HI @poojakural thanks for the re-roll.I have reviewed the patch issue has found fixed

attaching screenshot for the multiple buttons:

I tested this by setting Olivero to be the administration theme (once again, this isn't a use case we'll support), and then going to Block Layout, and hitting the "Place Block" button.

I see that it's not using the template that's included in the patch, it's using the core/modules/system/templates/menu-local-action.html.twig template.

To fix this we need

1) Do we need our own template? Since the one in the patch is not being utilized, I don't believe so
2) If we do need our own template, lets abstract the actions into its own library and call it from the template using attach_library.

Hi @mherchel i have updated the patch with your above concerns.

1. i have removed the block--local-actions-block.html.twig template.
2. Added menu-local-action.html.twig template and attached the library through template.

Please review my patch.

Looks good!

Committed. Thanks!