Include bootstrap.inc using composer

This way we can load/define requirement constants too!
Nice idea and easy to get rid of when bootstrap.inc will be purged

+++ b/core/tests/Drupal/Tests/Core/DrupalKernel/DrupalKernelTest.php
@@ -1,195 +1,183 @@
+      'www.blackhat.com',
+      'www.example.com',

One thing out of scope here. Should blackhat.com be changed?

Tagging. I also ponder what this means for contrib testing. Does this break anything for contrib unit tests, if they wrote them poorly?

re #11: that's my concern. If someone does it poorly, which isn't all that hard to do. But if we write up a good CR and do this in a new minor, the benefit from this change is really, really high.

This is looking really nice. Leaving in NR to get some more feedback from others.

BTW, updated CR that added "After" (section) to pair with "Before", or looks incomplete at the first glimpse. See
https://www.drupal.org/node/3151229/revisions/view/11942291/11942414

+2 on removing all the require 'bootstrap.inc'; type lines from everywhere in the codebase.

-1 on leaving bootstrap.inc the way it is, because the constants should be moved out from it, and the functions need to be rolled somewhere else, as per some issues in #3097045: [META] Provide modern replacements for and deprecate the legacy include files.

So that's a net positive. :-)

For other include files that have lots of require statements like this, maybe we should do the same thing with them. I can't think of which ones those would be offhand, though.

Tempted to add the 'Kill includes' tag, but this doesn't really do that.

It's out of scope here but I've always maintained that the constants should be in a different file from the functions in bootstrap.inc, so that we can use constants without the overhead of the functions.

The big problem has been tests that need those constants but which also shouldn't load the functions in bootstrap.inc for whatever reason. Like more strict unit tests. I haven't been neck-deep in that code for a while, so if that's not an issue any more then, uh, it's not an issue. :-)

Anyway, +1 on using composer to autoload this file and removing a bunch of extraneous require stuff. It just feels a little hacky rather than architected, and we'll probably eventually circle back to undoing this as things progress.

+1 for this issue

That would be great if we have only two files for load by Composer in Drupal 10: constants.php and functions.php.
No more *.inc files. No more include files handled by the Kernel. Maybe fill a followup to address that before drupal:10.0.0-alpha1? Until then there would be the only bootstrap.inc file loaded by the Composer. So good so far.

#18 +1 for moving or deprecating of drupal_get_filename and watchdog_exception functions. I'm not sure that some code will use those function before Kernel initialization but small chance exist that situation may happen.

For reference, there are some issues to address the replacement of some functions in bootstrap.inc file:

• #3053773: Move shutdown functions into the shutdown handler class.
• #3000229: Add DrupalErrorHandler wrapping Symfony ErrorHandler component
• #2347783: Deprecate drupal_get_path() and drupal_get_filename() and replace with ExtensionList::getPath() and ExtensionList::getPathname()
• #3038513: Move drupal_generate_test_ua() into the test system
• #1577902: [META] Remove all usages of drupal_static() & drupal_static_reset()

The patch adds the autoloading of includes/bootstrap.inc
All occurrences of requiring the loading of includes/bootstrap.inc by "hand" are removed.
All code changes look good to me.
For me it is RTBC.

I am for continue to deprecated the contents of the file includes/bootstrap.inc. Hopefully someday we can remove the autoloading of the file from composer.json.

After applying the patch you need to rebuild your autoloader... removing vendor and running composer install should be enough.

BTW, tested:

• Running composer dump-autoload or composer dumpautoload is not enough
• Running composer install works without removing vendor.

Nice to see remains of st() are gone)

+++ b/core/modules/views/tests/src/Unit/EntityViewsDataTest.php
@@ -1195,24 +1195,3 @@ public function setKey($key, $value) {
-if (!function_exists('t')) {
...
-  function t($string, array $args = []) {
-    return strtr($string, $args);
...
-if (!function_exists('t')) {
...
-  function t($string, array $args = []) {
-    return strtr($string, $args);

+++ b/core/tests/Drupal/Tests/Core/Render/Element/MachineNameTest.php
@@ -111,13 +111,3 @@ public function testProcessMachineName() {
-if (!function_exists('t')) {
...
-  function t($string, array $args = []) {
-    return strtr($string, $args);

It makes t() to work properly in tests

Patch no longer applies. I removed the section from the patch that has already been removed in core.

Forgot the interdiff...

Checked with $ git grep 'bootstrap.inc' and $ COMPOSER_ROOT_VERSION=9.1.x-dev composer update --lock -vvv, #31 looks good.

But the inter-diff file attached in #32 is incorrect. attaching a raw-interdiff file.

re-roll patch.

Updated the hash.

The patch adds the autoloading of includes/bootstrap.inc
All occurrences of requiring the loading of includes/bootstrap.inc by "hand" are removed.
All code changes look good to me.
Reroll looks good to me.
For me it is RTBC.

Only thing that makes me hesitant here is we should have done it pre-8.0.0, but better late than never. Committed/pushed to 9.2.x and 9.1.x, thanks!