The channels field doesn't work as intended. It asks that we put each channel on a new line, however two functions that explode/implode the newline are not using double quotes. Therefore any channels identified here (unless there is just one) will be ignored.
Needs double quotes instead of single. Proposed patch attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | filelog-3150988-interdiff-4-6.txt | 783 bytes | cburschka |
| #7 | filelog-3150988-6.patch | 4.6 KB | cburschka |
| #7 | filelog-3150988-6-testonly.patch | 3.73 KB | cburschka |
| #4 | filelog-3150988-4.patch | 4.61 KB | cburschka |
| #4 | filelog-3150988-4-testonly.patch | 3.73 KB | cburschka |
Comments
Comment #2
mrinalini9 commentedRerolled patch as it failed to apply, please review.
Comment #3
cburschkaGreat catch, thanks!
I'll add a unit test for this
Comment #4
cburschkaFunctional test, since this is form code.
Comment #7
cburschkaComment #10
cburschkaPushed. Thanks very much for this fix!
Comment #11
cburschka