Search bar is not themed.

CommentFileSizeAuthor
#15 Before-patch.png14.47 KBshaktik
#13 after-patch.png4.01 KBgauravvvv
#11 afterPatch.png75.64 KBRuchi Joshi
#11 beforePatch.png74.73 KBRuchi Joshi
#8 3149890-8.patch667 bytesshaktik
#7 issue-fixed-3149890-7.patch963 bytesgauravvvv
#5 search-bar-styled-3149890-5.patch698 bytesgauravvvv
#4 search_before_patch.png3.81 KBRuchi Joshi
#2 search-bar-styled-3149890-2.patch366 bytesgauravvvv
Screenshot (145).png1.83 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new search-bar-styled-3149890-2.patch366 bytes

I have provided the patch please verify if it is working or not.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
Ruchi Joshi’s picture

Ruchi Joshi commented
StatusFileSize
new search_before_patch.png3.81 KB

Issue is reproducible. Attaching screenshot for the same.(search_before_patch.png)
But I was not able to apply the patch since patch is corrupted.

C:\MAMP\htdocs\drupal-8.9.0\themes\busy>git apply -v search-bar-styled-3149890-2.patch
error: corrupt patch at line 17
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new search-bar-styled-3149890-5.patch698 bytes

@ruchi joshi I have provided the patch with correct indents, Please verify if it is working or not.

Ruchi Joshi’s picture

Ruchi Joshi commented

@Gauravmahlawat - I tried applying patch(search-bar-styled-3149890-5.patch) provided by you. but its throwing error:

search-bar-styled-3149890-5.patch:17: trailing whitespace.

search-bar-styled-3149890-5.patch:23: trailing whitespace.
  width: 110px;
Checking patch css/style.css...
error: while searching for:
img {
  max-width: 100%;
}

error: patch failed: css/style.css:889
error: css/style.css: patch does not apply
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new issue-fixed-3149890-7.patch963 bytes

@ruchi_joshi Please try with this patch.

shaktik’s picture

shaktik
he/him
Primary language Hindi
Location New Delhi
commented
StatusFileSize
new 3149890-8.patch667 bytes

Hi @Gauravmahlawat,

patch #7 no longer to apply, updated latest patch kindly check.

gauravvvv’s picture

gauravvvv commented

@shaktik Patch #8 is working on my side, ready to RTBC.

gauravvvv’s picture

gauravvvv commented
Status: Needs review » Reviewed & tested by the community
Ruchi Joshi’s picture

Ruchi Joshi commented
StatusFileSize
new beforePatch.png74.73 KB
new afterPatch.png75.64 KB

Issue is fixed now. +1for RTBC

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Uhm, could you please describe how the search block should look like?
If I compare https://www.drupal.org/files/issues/2020-07-30/beforePatch.png with https://www.drupal.org/files/issues/2020-07-30/afterPatch.png, the output in "afterPatch.png" looks broken to me.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new after-patch.png4.01 KB

I think patch #8 is not applied properly in your system @ruchijoshi. here I have provided after patch screenshot please verify. Because ptch contains "display: flex" property and in your after patch picture flex is not applied.

gauravvvv’s picture

gauravvvv commented
Status: Postponed (maintainer needs more info) » Needs review
shaktik’s picture

shaktik
he/him
Primary language Hindi
Location New Delhi
commented
StatusFileSize
new Before-patch.png14.47 KB

Hi @Gauravmahlawat, @Ruchi Joshi

I think default theme looks good to me for search bar attached screenshot.

interdiff patch #7 and #8 - css/style.css: {}

shweta__sharma’s picture

shweta__sharma commented

These two patches doesn't work for me
When i applied patch #8 3149890-8.patch showing this error
error: Checking patch css/style.css...
error: while searching for:
img {
max-width: 100%;
}
error: patch failed: css/style.css:889
error: css/style.css: patch does not apply

When i applied search-bar-styled-3149890-2.patch showing this error
error: $ git apply -v search-bar-styled-3149890-2.patch.txt
error: corrupt patch at line 17