Pager items not styled.

CommentFileSizeAuthor
#10 Issue fixed_afterPatch(2).JPG9.61 KBpankaj.singh
#10 Issue fixed_afterPatch(1).JPG12.8 KBpankaj.singh
#10 pager alignment issue_beforePatch.JPG14.1 KBpankaj.singh
#8 issue-resolved-3149851-8.patch586 bytesgauravvvv
#6 pager not alligned.JPG15.55 KBpankaj.singh
#3 pager-item-styled-3149851-3.patch252 bytesgauravvvv
#2 pager-item-styled-3149851-2.patch736 bytesgauravvvv
Screenshot (143).png2.11 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new pager-item-styled-3149851-2.patch736 bytes

I have provided the patch please verify if it is working or not.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new pager-item-styled-3149851-3.patch252 bytes

I have provided the patch please verify if it is working or not.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
pankaj.singh’s picture

pankaj.singh commented

reviewing the patch

pankaj.singh’s picture

pankaj.singh commented
StatusFileSize
new pager not alligned.JPG15.55 KB

The issue reported is also reproducible on my end.

but the patch is failing to apply as it says corrupted.

C:\MAMP\htdocs\drupal-8.9.0\drupal-8.9.0\themes\busy>git apply -v pager-item-styled-3149851-3.patch
error: corrupt patch at line 11
pankaj.singh’s picture

pankaj.singh commented
Status: Needs review » Needs work
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new issue-resolved-3149851-8.patch586 bytes

@pankaj singh I have provided the patch please verify if it working or not last patch had a wrong indents issue that's why got corrupted.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
pankaj.singh’s picture

pankaj.singh commented
StatusFileSize
new pager alignment issue_beforePatch.JPG14.1 KB
new Issue fixed_afterPatch(1).JPG12.8 KB
new Issue fixed_afterPatch(2).JPG9.61 KB

@gauravmahlawat thanks for fixing the patch.

The patch is working fine on my end and fixes the issue reported. Attaching the SS for ref. RTBC+1

gauravvvv’s picture

gauravvvv commented
Status: Needs review » Reviewed & tested by the community

kunal_kapoor’s picture

kunal_kapoor commented
Status: Reviewed & tested by the community » Fixed
kunal_kapoor’s picture

kunal_kapoor commented
Status: Fixed » Closed (fixed)