Closed (fixed)
Project:
Module Builder
Version:
8.x-3.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Jun 2020 at 10:26 UTC
Updated:
24 Jun 2020 at 09:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
andrewmacpherson commentedLooking at the module
*.info.ymlfile andcomposer.jsonfiles before and after commit b45c94a, it seems like the intention is to say that Drupal core isn't supported prior to version 8.4.One way to address this is to use the Composer
conflictmechanism to say it can't be installed alongside an early version of D8.This patch:
core_version_requirementin the module's info file (to make the problem reported here go away).conflictrequirement to the Composer config (to keep enforcing the minimum Drupal core version).Comment #3
andrewmacpherson commentedUpdating the title to reflect the actual problem - and make more sense in my cweagans/composer-patches config :-)
Comment #4
andrewmacpherson commentedAh, the patch in #2 applies against the dev branch of the module, but fails to apply against the 8.x-3.6 release because the Drupal.org packaging script adjusts the
core: 8.xline.This version of the patch is a sneaky workaround with fewer lines of context (
git diff --unified=0). It should apply to the dev current dev branch or the packaged 8.x-3.6 release.Comment #5
andrewmacpherson commentedIt might of course be easier to just drop support for Drupal core prior to 8.7.7
Comment #7
joachim commentedSorry -- I read the docs about how to mark core compatibility and they were pretty confusing.
> It might of course be easier to just drop support for Drupal core prior to 8.7.7
Generally, MB/DCB tries to support older versions to people stuck on those can still generate code. So if there's a way to specify core 8.4 as the minimum, that would be best.
I've committed @andrewmacpherson's first patch and I'll make a new release today.
Thanks everyone!