Problem/Motivation

Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 9.

To read more about this effort by the Drupal Association, please read: Accelerating Drupal 9 module and theme readiness with automated patches

Periodically patches will be added to this issue that remove Drupal 9 deprecations. To stop further patches from being posted simply close this issue(any status besides Active, Needs Review or Needs work) or remove the "ProjectUpdateBotD9" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open(status of Active, Needs Review or Needs work) and the "ProjectUpdateBotD9" tag is left on this issue, new patches will be posted periodically if new deprecations are needed.

    As the Drupal Rector project improves and is able to fix more deprecations the patches posted here will cover more of the deprecations in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecations but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD9" from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again simply add back the "ProjectUpdateBotD9" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful they can simply close this issue(any status besides Active, Needs Review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 9 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear,  use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new1.24 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 9 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 9.

Currently Drupal-Rector, version 0.5.6, cannot fix all Drupal 9 compatibility problems.

This patch does not update the info.yml file for Drupal 9 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 9 compatibility fixes as they become available in Drupal-Rector.

Debug info

Bot run #1478

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 0.12.3
  2. palantirnet/drupal-rector: 0.5.6
  3. rector/rector-prefixed: v0.7.29
adamps’s picture

Issue summary: View changes

The patch is OK as far as it goes. Unfortunately there is a bigger problem that the Bot doesn't notice: the tests still use simpletest which is missing from D9.

samitk’s picture

Patch for

  • Drupal 9 compatibility.
  • Update WebTestBase class with BrowserTestBase.

Status: Needs review » Needs work

The last submitted patch, 4: private_content-Drupal-9-compatibility-3148486-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

samitk’s picture

Patch for

  • Drupal 9 compatibility.
  • converted to PHPUnit Browser test.
  • Updated WebTestBase class with BrowserTestBase.
samitk’s picture

Status: Needs work » Needs review
StatusFileSize
new6.27 KB

Update code to fix failed tests.

  • Drupal 9 compatibility.
  • converted to PHPUnit Browser test.
  • Updated WebTestBase class with BrowserTestBase.
adamps’s picture

Status: Needs review » Needs work

Great many thanks. This is looking really good. It still needs work please:

  1. Fix coding standards messages. Please delete the calls to debug() instead of commenting out.
  2. Fix deprecation notices causing the D9 tests to fail.
samitk’s picture

Status: Needs work » Needs review
StatusFileSize
new6.29 KB

Patch for:

  • Drupal 9 compatibility changes.
  • Converted simpletest to PHPUnit Browser test, as simpletest is not used in Drupal 9.
  • Updated WebTestBase class with BrowserTestBase.
  • Fixed coding standards.
adamps’s picture

Status: Needs review » Needs work

adamps’s picture

Status: Needs work » Active

OK it's a good start thanks, I have committed it.

However the tests are not yet passing on Drupal 9. If you click on the test result for #9 Drupal 9 (the red part) then scroll down you will see "Remaining self deprecation notices (41)". The next step for this issue is to fix those.

samitk’s picture

Assigned: Unassigned » samitk
samitk’s picture

Status: Active » Needs review
StatusFileSize
new4.58 KB

Hi AdamPS, I have resolved all the errors (Remaining self deprecation notices (41)). Please check.

Patch for:

  • Drupal 9 compatibility changes.
  • Converted simpletest to PHPUnit Browser test, as simpletest is not used in Drupal 9.
  • Updated WebTestBase class with BrowserTestBase.
  • Fixed coding standards.
  • Fixed Remaining self deprecation notices (41) Errors, mentioned in #12.
samitk’s picture

Assigned: samitk » Unassigned
adamps’s picture

Status: Needs review » Active

Thanks. I committed your patch then made an extra commit to fix a single line.

samitk’s picture

Hi AdamPS, the status is still Active, Is there anything else that remains?

adamps’s picture

Nothing for now thanks. However we want the UpdateBot to keep checking - see the issue summary:

If this issue is left open(status of Active, Needs Review or Needs work) and the "ProjectUpdateBotD9" tag is left on this issue, new patches will be posted periodically if new deprecations are needed.

adamps’s picture

  • AdamPS committed 53138c2 on 8.x-2.x
    Issue #3148486 by AdamPS: Automated Drupal 9 compatibility fixes
    
joseph.olstad’s picture

Drupal 9 came and it's almost gone.

We'll need a small commit to fix D10 compatibility, see related issue:

#3289146: Automated Drupal 10 compatibility fixes

joseph.olstad’s picture

Status: Active » Fixed

Please continue with the related D10 issue:
#3289146: Automated Drupal 10 compatibility fixes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.