10/10 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


================================================================================
Firebase Cloud Messaging (FCM), --
Scanned on Fri, 06/05/2020 - 16:58

FILE: web/modules/contrib/firebase/src/Controller/FirebaseHelpController.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Fix later      70   Call to deprecated function system_get_info(). Deprecated in
                    drupal:8.8.0 and is removed from drupal:9.0.0. Use
                    \Drupal::service('extension.list.$type')->getExtensionInfo()
                    or
                    \Drupal::service('extension.list.$type')->getAllInstalledInf
                    o() instead.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/firebase/firebase.info.yml

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    Add <code>core_version_requirement: ^8 || ^9 to
                    modules/contrib/firebase/firebase.info.yml to designate that
                    the module is compatible with Drupal 9. See
                    https://drupal.org/node/3070687.
--------------------------------------------------------------------------------
CommentFileSizeAuthor
#10 site-3146559-10.png52.73 KBkleiton_rodrigues
#10 firebase-remove_deprecated_code_for_drupal_9_compatibility-3146559-10-D8.patch2.8 KBkleiton_rodrigues
#10 3146559-10.png49.99 KBkleiton_rodrigues
#8 3146559-3-D8.patch2.74 KBthalles
#2 3146559-2.patch2.75 KBashutosh.mishra

Issue fork firebase-3146559

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ashutosh.mishra created an issue. See original summary.

ashutosh.mishra’s picture

ashutosh.mishra commented
StatusFileSize
new 3146559-2.patch2.75 KB
ashutosh.mishra’s picture

ashutosh.mishra commented
Assigned: ashutosh.mishra » Unassigned
Status: Active » Needs review

jrglasgow made their first commit to this issue’s fork.

jrglasgow opened merge request !1

anish.a’s picture

anish.a commented
Related issues: +#3140565: Automated Drupal Rector fixes
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs review » Needs work

Needs reroll!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new 3146559-3-D8.patch2.74 KB

Follow a new patch

kleiton_rodrigues’s picture

kleiton_rodrigues commented
Assigned: Unassigned » kleiton_rodrigues
kleiton_rodrigues’s picture

kleiton_rodrigues commented
Assigned: kleiton_rodrigues » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3146559-10.png49.99 KB
new firebase-remove_deprecated_code_for_drupal_9_compatibility-3146559-10-D8.patch2.8 KB
new site-3146559-10.png52.73 KB

@thalles was added to the variable within the function __construct and a new patch was generated,
now it works fine, moving to RTBC.

3146559

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Thanks @all!
+ RTBC

thalles closed merge request !1

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.