Comments

rik-dev created an issue. See original summary.

rik-dev’s picture

Status: Active » Needs review
StatusFileSize
new385 bytes
msuthars’s picture

Assigned: Unassigned » msuthars
Status: Needs review » Needs work
StatusFileSize
new746.45 KB

msuthars’s picture

StatusFileSize
new16.31 KB
new17.7 KB

Fixed the deprecation issues and updated the patch. Please review the patch.

msuthars’s picture

Assigned: msuthars » Unassigned
Status: Needs work » Needs review
masipila’s picture

I would really appreciate if the community members could help testing and reviewing the patches. I'm currently building a house so my own time is very limited...

In addition to code reviews, I would like to see somebody posting test reports of manual testing detailing which features of the module you have tested.

Cheers,
Markus, module maintainer

parvateesam’s picture

Assigned: Unassigned » parvateesam
parvateesam’s picture

Issue tags: +DIACWJuly2020

I tried this module on Drupal 9 but due to dependency of rules module i am not able to verify. Please find the rules project information below for the same.

Drupal 9 is here!
Rules cannot be compatible with Drupal 9 until https://www.drupal.org/project/drupal/issues/3126747 is fixed. If you want to help make Rules compatible with Drupal 9, please participate in that issue.

Rules will also not sacrifice compatibility with the currently-supported versions of Drupal core, so Drupal 9 will not be supported until Drupal 8.8 is the lowest-supported version of Drupal core. The issues that are postponed because of this are listed in https://www.drupal.org/project/rules/issues/3089502

masipila’s picture

Thanks @Parvateesam for your efforts so far!

You should be able to proceed with your tests (all except Rules integration, of course) if you delete the modules/simple_fb_connect_rules directory from your dev environment.

Cheers,
Markus

kaythay’s picture

Assigned: parvateesam » Unassigned

  • kaythay committed d8ce144 on 8.x-3.x authored by msuthars
    Issue #3145708 by msuthars, rik-dev: Drupal 9 compatibility
    
kaythay’s picture

Status: Needs review » Fixed

Making the D9 release shortly. Thanks everyone for your contributions!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.