Call to deprecated method getStorage() of class Drupal\Core\Entity\EntityManager. Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Use Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() instead.

CommentFileSizeAuthor
#8 views_condition-drupal_9_upgrade_composer_patch-3145553-9-8.x.patch1.35 KBeduardo morales alberti
#7 views_condition-drupal_9_upgrade-3145553-7-8.x.patch1.35 KBeduardo morales alberti
#7 interdiff_6_7.txt311 byteseduardo morales alberti
#6 interdiff_3-6.txt883 bytessuresh prabhu parkala
#6 3145553-6.patch1.35 KBsuresh prabhu parkala
#4 3145553-4.patch1.35 KBsuresh prabhu parkala
#3 3145553-3.patch354 bytesdrupal.ninja03
#3 interdiff-3145553-2-3.txt1.35 KBdrupal.ninja03
#2 3145553-2.patch1 KBmo_farhaz

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz commented
Assigned: mo_farhaz » Unassigned
Status: Active » Needs review
StatusFileSize
new 3145553-2.patch1 KB

please review

drupal.ninja03’s picture

drupal.ninja03 commented
StatusFileSize
new interdiff-3145553-2-3.txt1.35 KB
new 3145553-3.patch354 bytes

Tested the patch from #2 and added one patch to address below warning:

Add core_version_requirement: ^8 || ^9 to modules/contrib/views_condition/views_condition.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
StatusFileSize
new 3145553-4.patch1.35 KB

Combined both patch of #2 and #3. Please review.

drupal.ninja03’s picture

drupal.ninja03 commented
Status: Needs review » Needs work

Hi @suresh, Please provide an interdiff file to show what changes have been added.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 3145553-6.patch1.35 KB
new interdiff_3-6.txt883 bytes

Please review!

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
StatusFileSize
new interdiff_6_7.txt311 bytes
new views_condition-drupal_9_upgrade-3145553-7-8.x.patch1.35 KB

Remove core from info, because patch does not apply using composer patches, drupal org comment the core line and added it again automatically so is not necessary to have it.

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
StatusFileSize
new views_condition-drupal_9_upgrade_composer_patch-3145553-9-8.x.patch1.35 KB

Adapted patch to apply using composer patches.

pookmish’s picture

pookmish commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.