Closed (fixed)
Project:
Scheduler
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Jun 2020 at 08:49 UTC
Updated:
22 Jun 2020 at 14:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
chr.fritschHere is a patch
Comment #3
jonathan1055 commentedThanks chr.fritsch
I was thinking that after a user installs/upgrades to 8.x-1.2 the cache would be cleared and the schema default value would become available. Is that only done if they uninstall and reinstall the module?
If so, then this your
scheduler_update_8002()should be committed and I need to release 1.3.Alternatively, site admins can simply visit the settings page and save again (without making any changes). That should re-save the new default.
What a pain, for either option.
Comment #4
chr.fritschThis only happens after a re-install. New config values get only imported on an install. If new values get introduced with a new module version, they have to be set manually.
I think that would be best.
This works, but it's not so nice. It would be best that after an update everything works like before.
Comment #5
jonathan1055 commentedYes, you are so right. I wish I had remembered about the new config value before the release. I know that Core have tests for upgrading, but all of the scheduler tests are based on a clean install, so the new test I wrote for this config worked fine. Is there a simple way to run the phpunit tests automatically within our test runs on an upgraded site as well as a cleanly installed site?
Comment #6
chr.fritschAFAIK there is only UpdatePathTestBase to test the upgrade path. But there is no possibility to run all the tests against an existing installation.
Comment #7
jonathan1055 commentedThanks. Just looked at that, and yes it is not what we need here. That tests the functionality of a
update_n()call. My problem was that I forgot to write the update_n() in the first place.Currently there are 543 installations using 8.x-1.2 and still 26,000 using 1.0 or 1.1
So now is probably the time to make the new quick release, before too many more users are inconvenienced.
Comment #8
chr.fritschYes, go for it 💪
Comment #10
jonathan1055 commentedI changed the function name to
scheduler_update_8101()to align the the naming convention of hook_update_n. I also moved the @see out of the doc block and into the body because the entire function doc block is shown in the update.php page but it it unformatted and just a plain string of text with no punctuation (so is fairly meaningless, and untidy)Fixed and committed. I will release 1.3 in a few days - just giving time for anything else to emerge which needs an important fix.
Comment #11
jonathan1055 commented@chr.fritsch you have probably noticed already but I have released Scheduler 8.x-1.3
Had to do some tedious work to add back the Rules requirements for the release, then remove then in -dev to allow testing at D9 to succeed. See #3136553: Cannot use Rules module in D9. If you are using Scheduler 1.3 with SCMI testing you will find that it fails at D9 on Rules requirements. You can apply this patch to allow it to work at D9.