Top margin appears to be missing.

CommentFileSizeAuthor
#15 afterapplypatch.JPG169.7 KBshweta__sharma
#13 After applying patch.png70.04 KBrahulranade
#13 Before applying patch.png67.58 KBrahulranade
#11 margin-issue-3144756-11.patch922 bytessarvjeetsingh
#6 margin-issue-3144756-6.patch239 bytesgauravvvv
#2 header-issue-resolved-3144756-2.patch232 bytesgauravvvv
Screenshot (115).png204.35 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new header-issue-resolved-3144756-2.patch232 bytes

I have provided the patch please verify if it is working or not.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
lokeshsahu’s picture

lokeshsahu commented
Assigned: Unassigned » lokeshsahu
lokeshsahu’s picture

lokeshsahu commented
Assigned: lokeshsahu » Unassigned
Status: Needs review » Needs work

The created patch is incorrect. Please provide the correct patch

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new margin-issue-3144756-6.patch239 bytes

Please verify the patch if it is working or not.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
rahulranade’s picture

rahulranade commented
Assigned: Unassigned » rahulranade
rahulranade’s picture

rahulranade commented
Assigned: rahulranade » Unassigned
Status: Needs review » Needs work

The #6 patch can't be applied because it does not have a new line at the end.

sarvjeetsingh’s picture

sarvjeetsingh commented
Assigned: Unassigned » sarvjeetsingh
sarvjeetsingh’s picture

sarvjeetsingh commented
Assigned: sarvjeetsingh » Unassigned
Status: Needs work » Needs review
StatusFileSize
new margin-issue-3144756-11.patch922 bytes

fixed the margin issue.
please review.

rahulranade’s picture

rahulranade commented
Assigned: Unassigned » rahulranade
rahulranade’s picture

rahulranade commented
StatusFileSize
new Before applying patch.png67.58 KB
new After applying patch.png70.04 KB

Patch #11 is applied successfully.

Testing Steps Followed:
- Installed the theme.
- Applied the patch
- Navigates to homepage

Looks good to me.
Can be a move to RTBC
Please refer attached screenshots.

rahulranade’s picture

rahulranade commented
Assigned: rahulranade » Unassigned
Status: Needs review » Reviewed & tested by the community
shweta__sharma’s picture

shweta__sharma commented
StatusFileSize
new afterapplypatch.JPG169.7 KB

Patch applied successfully

vinitk’s picture

vinitk commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.