Reviewed & tested by the community
Project:
International Phone Field
Version:
8.x-1.0
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
1 Jun 2020 at 04:54 UTC
Updated:
5 Jan 2022 at 08:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mo_farhaz commentedplease review
Comment #3
burningdog commentedThe patch applies but the module has an error in that it tries to access removed code, namely
SafeMarkup::checkPlain()which was deprecated in Drupal 8 and removed in Drupal 9:https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Util...
Switching to use
\Drupal\Component\Utility\Html::escape()instead allowed for the module to be installed and aninternational_phonefield can be added to a content type. However, there are the following problems:* it uses the hard-coded
Streetlabel instead of the label given in the field settingsThe JavaScript fails with
*
Uncaught TypeError: e.indexOf is not a functionin JQuery, tracing back to line 56 ofintlTelInput.js*
Uncaught TypeError: $(...).intlTelInput is not a function.Instead, I've switched to using https://www.drupal.org/project/phone_international
Comment #4
edsoncarlos commentedComment #5
renatog commented#4 really looks good
Comment #6
kunalgautam commented#4 working file for me. can it merge this into the current module?
Comment #7
rescudero commentedThe patch was giving me an error adding core_version_requirement: ^ 8 || ^ 9
I have modified that part and it has worked for me
Comment #8
rescudero commentedI upload the corrected patch, the previous one had the path of the file with my own project