Problem/Motivation

In https://www.drupal.org/node/3111075 the buttons in the UI were made smaller for Claro by adding a .button--small class to them. However the "Add above" button wasn't changed and it's now larger than the other buttons.

Two buttons of different sizes placed on top of each other.

Proposed resolution

Add the .button--small class to the "Add above" button to make it the same size as the other buttons.

Two buttons of same size placed on top of each other.

CommentFileSizeAuthor
#6 claro-small-add-above-button-3143549-3-against-stable.patch2.06 KBsasanikolic
#3 claro-small-add-above-button-3143549-3.patch2 KBsasanikolic
#3 claro-small-add-above-button-3143549-3-interdiff.txt1012 bytessasanikolic
#2 claro-small-add-above-button-3143549-2.patch1.01 KBgaards
claro-same-size-add-above-button.png6.7 KBgaards
claro-bigger-add-above-button.png7.75 KBgaards

Comments

gaards created an issue. See original summary.

gaards’s picture

gaards commented
Status: Active » Needs review
StatusFileSize
new claro-small-add-above-button-3143549-2.patch1.01 KB

Patch attached

sasanikolic’s picture

sasanikolic commented
StatusFileSize
new claro-small-add-above-button-3143549-3-interdiff.txt1012 bytes
new claro-small-add-above-button-3143549-3.patch2 KB

Looks good to me. Just added a test for this.

sasanikolic’s picture

sasanikolic commented
Status: Needs review » Needs work

Let's also add that to the "Convert..." button.

sasanikolic’s picture

sasanikolic commented
Status: Needs work » Needs review

Nevermind about the previous comment, that's not committed yet (this issue). :)

sasanikolic’s picture

sasanikolic commented
StatusFileSize
new claro-small-add-above-button-3143549-3-against-stable.patch2.06 KB

Here is a patch against stable. The latest patch didn't apply for our project.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Committed.

  • Berdir committed 8d7c657 on 8.x-1.x authored by sasanikolic 
    Issue #3143549 by sasanikolic, gaards: Use small button class for the "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.