Use the small button component for Claro:
Buttons should gain the new buton--small class for Claro to use the smaller variant of buttons in the UI.
.button--small
should be added to the markup of the "Remove" & "Add" buttons.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | claro-small-buttons-3111075-10-interdiff.txt | 877 bytes | gaards |
| #10 | claro-small-buttons-3111075-10.patch | 5.03 KB | gaards |
| #7 | claro-small-buttons-3111075-7-interdiff.txt | 3.58 KB | sasanikolic |
| #7 | claro-small-buttons-3111075-7.patch | 4.18 KB | sasanikolic |
| #7 | Button bugs.png | 100.18 KB | sasanikolic |
Comments
Comment #2
saschaeggiComment #3
saschaeggiPatch for small "Add" & "Remove" buttons.
Comment #4
saschaeggiComment #6
saschaeggiComment #7
sasanikolic commentedI noticed some more bigger buttons, especially fixed the ones in the dropdown coming from paragraphs_library. Also fixed some margins there.
The "Add Paragraph" button was left big on purpose after discussing it with @berdir, since it's the primary button and should be bigger, IMHO.
Maybe we need some maintainers input regarding those decisions (@miro_dietiker) before continuing here.
Also noticed various issues when you change the add mode to just "Buttons", for example, paddings are missing below buttons. And nested "Add paragraph" buttons are missing right margin between the text and the button. Will create a followup for that.
Comment #9
berdirMiro confirmed that's OK, but looks like we have a test fail that needs to be fixed here?
Comment #10
gaards commentedI added a patch that should fix the test.
Comment #11
saschaeggi@berdir can you have another look at it with the patch from gaards? It works for me and it passes :) Thanks!
Comment #13
berdirSeems like we shouldn't hardcode the exact list of classes and their order in the test, but this isn't making it worse. So, lets do this.