I get the following report on running upgrade status module:
Simple XML Sitemap
Scanned on Tue, 05/26/2020 - 18:28.
1 warning found.
modules/contrib/simple_sitemap/modules/simple_sitemap_views/src/EventSubscriber/
ArgumentCollector.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check │ 69 │ Parameter $event of method │
│ manually │ │ Drupal\simple_sitemap_views\EventSubscriber\ArgumentCollecto │
│ │ │ r::onTerminate() has typehint with deprecated class │
│ │ │ Symfony\Component\HttpKernel\Event\PostResponseEvent: since │
│ │ │ Symfony 4.3, use TerminateEvent instead │
│ │ │ │
└───────── ─┴──────┴──────────────────────────────────────────────────────────────┘
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 3142942-13.patch | 1.44 KB | pratik_kamble |
| #5 | 3142942-simple_sitemap-5.patch | 1.38 KB | vivek panicker |
| simple_sitemap_deprecation_report.txt | 8.94 KB | vivek panicker |
Comments
Comment #2
vivek panicker commentedComment #3
vivek panicker commentedComment #4
vivek panicker commentedSorry for uploading the wrong file!!!
Comment #5
vivek panicker commentedFixed the path in the patch file.
Comment #6
gbyteIs the D9 branch supposed to fail?
Comment #7
vivek panicker commentedComment #8
vivek panicker commentedThis probably failed because
simple_sitemap_viewsandsimple_sitemap_views_testwere not compatible with Drupal 9 because of missingcore_version_requirementin their info files.I have added them in this patch and retesting with D9.
Comment #9
vivek panicker commentedCorrected file permission issue because of which patch was not applying.
Comment #10
vivek panicker commentedThe patch #5 seems to be good. There might be a problem with file permissions, but I can get that changed if required.
As for the error being reported, it is something related to settings.php/jenkins which I cannot understand if it is happening because of application of the patch.
https://www.drupal.org/pift-ci-job/1701674
Comment #11
vivek panicker commentedComment #12
pratik_kambleComment #13
pratik_kamble@Vivek Panicker thanks for the patch. But it is not applicable. Adding new patch to fix the deprecation warning.
Comment #14
pratik_kambleComment #15
hardik_patel_12 commented@pratik_kamble , @Vivek Panicker thanks for your efforts . I have verified that all Symfony\Component\HttpKernel\Event\PostResponseEvent is properly replaced with the Symfony\Component\HttpKernel\Event\TerminateEvent. So moving to RTBC.
Comment #16
berdirThis is a Drupal 9 deprecation, this will not work in Drupal 8. It can't be committed until the module requires Drupal 9. Don't run deprecation tests on Drupal 9, you get the wrong kind of deprecations then.
Comment #17
berdirHm, no test fail, maybe this submodule has no tests?
Comment #18
gbyte