From chx: here is the cycle to be tested

1. Make sure forum, comment and taxonomy is disabled.
2. Enable forum module.
3. Assert that you got the confirm form.
4. Press confirm.
5. Assert all three are on, then disable forum
6. Assert that comment and taxonomy are still on, then disable them.
7. Switch forum, comment and taxonomy on.
8. Assert there is no confirm form.
9. Assert all three are on.

CommentFileSizeAuthor
#6 system-module_page_test-314285-6.patch8.13 KBdmitrig01
#5 system-module_page_test-314285-5.patch8.09 KBdmitrig01
#3 system-module_page_test-314285-3.patch6.27 KBdmitrig01
#2 system-module_page_test-314285-2.patch6.29 KBdmitrig01
#1 system-module_page_test-314285-1.patch5.67 KBdmitrig01

Comments

dmitrig01’s picture

dmitrig01 commented
Status: Active » Needs review
StatusFileSize
new system-module_page_test-314285-1.patch5.67 KB

Here it is

dmitrig01’s picture

dmitrig01 commented
StatusFileSize
new system-module_page_test-314285-2.patch6.29 KB

re-rolled as per chx

dmitrig01’s picture

dmitrig01 commented
StatusFileSize
new system-module_page_test-314285-3.patch6.27 KB

extra whitespace

CorniI’s picture

CorniI commented
Status: Needs review » Needs work

The System simpletests are failing with:

An error occurred. /drupal7/?q=batch&id=44&op=do
Fatal error: Call to undefined method EnableDisableCoreTestCase::assertXPath() in /var/www/drupal7/modules/system/system.test on line 52

dmitrig01’s picture

dmitrig01 commented
Status: Needs work » Needs review
StatusFileSize
new system-module_page_test-314285-5.patch8.09 KB

Adding assertXPath.

dmitrig01’s picture

dmitrig01 commented
StatusFileSize
new system-module_page_test-314285-6.patch8.13 KB

Oops, flawed logic in assertXPath. I have bad copy-paste-fu

chrisshattuck’s picture

chrisshattuck commented
Status: Needs review » Needs work

Hey dimitri, the patch didn't apply. Thanks for your help with the testing!

catch’s picture

catch
he/him
Primary language English
commented
Component: tests » base system
Priority: Critical » Normal

Fixing the critical / pending bugs queues to reflect things which are really bugs or release critical.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.