Replace usages of deprecated AssertLegacyTrait::assert(No)Option()

Adding the "Deprecated assertions" tag to add this into the kanban board https://contribkanban.com/board/Deprecatedassertions

The patch needs a reroll, because #3139218: Replace usages of AssertLegacyTrait::assertResponse(), which is deprecated landed.

Rerolled patch for 9.1.x, please review.

All occurrences of $this->assert(No)Option() have been replaced by $this->assertSession()->option(Not)Exists().
The method was already deprecated in 8.2.
Test has been added for deprecation testing for both methods.
The supression of the deprecation message has been removed for both methods.
All code changes look good to me.
For me it is RTBC.

BTW I'm going to start recommending for these issues that we not do cleanups like removing the message parameters in the same patches. (#3132964: assertResponse() does not actually support a $message parameter, so stop passing one was different because that was the bug.) If we notice message parameters that aren't helpful, we can remove them and/or move them to inline documentation in separate issues.

Committed to 9.1.x. Let's make backport versions of this patch without the unsilencing of the deprecation message.

The backport here can include the same changes as the original commit. Please do make note of #12 for subsequent issues, though. If you notice unhelpful message parameters while patching, just make note of them and stick them in a followup.

On this.

Patch for D9.0 and D8.9

Added 8.8.x test in #19

Fixing failed test.

Patch for D8.8

The occurrences have been replaced by $this->assertSession().
Changes verified on my local for D8.8, D8.9,D9.0
Looks good to me.Moving this to RTBC
Thanks

Unfortunately we need a reroll for 9.0.x / 8.9.x patch.

Patch rerolled for branch 8.9.x. Interdiff is not generated from #23

Please ignore the last patch, Here is the latest patch that rerolled for both the branches 9.0.x / 8.9.x . Thanks Please review.