drupal-check modules/contrib/galleryslider

 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ----------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldFormatter/GallerySliderFieldFormatter.php                    
 ------ ----------------------------------------------------------------------------------- 
  57     Call to deprecated method getStorage() of class Drupal\Core\Entity\EntityManager:  
         in drupal:8.0.0 and is removed from drupal:9.0.0.                                  
         Use \Drupal\Core\Entity\EntityTypeManagerInterface::getStorage() instead.
CommentFileSizeAuthor
#11 interdiff-3139135-7-11.txt559 bytesmrinalini9
#11 d9_deprecated_code_report-3139135-11.patch1.35 KBmrinalini9
#7 interdiff-3139135-2-7.txt271 bytesmrinalini9
#7 d9_deprecated_code_report-3139135-7.patch1 KBmrinalini9
#2 d9_deprecated_code_report-3139135-2.patch691 bytesyonas.legesse

Comments

yonas.legesse created an issue. See original summary.

yonas.legesse’s picture

yonas.legesse commented
Status: Active » Needs review
StatusFileSize
new d9_deprecated_code_report-3139135-2.patch691 bytes

Made change and confirmed error free output.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Drupal 9 porting weekend

Presuming this is for Drupal 9 porting weekend since this was created during that time.

dharizza’s picture

dharizza commented
Status: Needs review » Reviewed & tested by the community

Hello!
I scanned this with upgrade_status module, before applying the patch I got the issue described here, after applying the patch and re-running the scan this issue was cleared.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Reviewed & tested by the community » Needs work

Thanks everyone! I would suggest merging the patch from #3139140: Add core version requirement and close that one to save time for the maintainer. The scope of this one covers that one's, no need to rescope here.

mrinalini9’s picture

mrinalini9 commented
Assigned: Unassigned » mrinalini9
mrinalini9’s picture

mrinalini9 commented
Assigned: mrinalini9 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new d9_deprecated_code_report-3139135-7.patch1 KB
new interdiff-3139135-2-7.txt271 bytes

Updated patch as suggested in #5, please review.

mrinalini9’s picture

mrinalini9 commented
Issue tags: +DIACWMay2020
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs review » Needs work

Thank you @mrinalini9!

One more left to go:


CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Gallery slider 8.x-1.x-dev
Scanned on Sat, 05/23/2020 - 14:44.

1 error found.

Pledge to have it ready before the Drupal 9 release date.

web/modules/contrib/galleryslider/src/Plugin/Field/FieldFormatter/GallerySliderF
ieldFormatter.php:
┌─────────┬──────┬──────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                       MESSAGE                        │
├─────────┼──────┼──────────────────────────────────────────────────────┤
│ Fix now │ 185  │ Call to deprecated method urlInfo() of class         │
│         │      │ Drupal\Core\Entity\EntityInterface. Deprecated in    │
│         │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Use   │
│         │      │ Drupal\Core\Entity\EntityInterface::toUrl() instead. │
│         │      │                                                      │
└─────────┴──────┴──────────────────────────────────────────────────────┘
mrinalini9’s picture

mrinalini9 commented
Assigned: Unassigned » mrinalini9
mrinalini9’s picture

mrinalini9 commented
Assigned: mrinalini9 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new d9_deprecated_code_report-3139135-11.patch1.35 KB
new interdiff-3139135-7-11.txt559 bytes

Updated patch as mentioned in #9, please review.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs review » Reviewed & tested by the community

Checked on my local. No known errors. It is good to go to me. Thank you @mrinalini9!

For the issue marked as a duplicate, all people get involved in there are also here, so no need to taking extra care of the credit thing.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented

  • riazsaid15 committed 94d9f76 on 8.x-2.x 
    Issue #3139135 by riazsaid15: Drupal 9 deprecated code report
riazsaid15’s picture

riazsaid15 commented

Thanks to all, I have added the above-mentioned issues.

xem8vfdh’s picture

xem8vfdh commented

is this merged? I see core_version_requirement: ^8 || ^9 in the 8.x-3.x branch's current info file...

ishfaqafridi85’s picture

ishfaqafridi85 commented
Status: Reviewed & tested by the community » Fixed

This fix was committed in 94d9f76 and is included in 8.x-3.1. Marking this fixed. Thanks to everyone who provided patches and tested the changes.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.