Add core version requirement to galleryslider.info.yml file.

CommentFileSizeAuthor
#4 core_version_requirement-3139140-4.patch335 bytesdharizza
#2 add_core_version_requirement-3139140-2.patch378 bytesyonas.legesse
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yonas.legesse created an issue. See original summary.

yonas.legesse’s picture

yonas.legesse CreditAttribution: yonas.legesse at Axelerant commented
Status: Active » Needs review
FileSize
add_core_version_requirement-3139140-2.patch378 bytes

Added Drupal 8 & 9 version requirement.

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Issue tags: +Drupal 9 porting weekend

Presuming this is for Drupal 9 porting weekend since this was created during that time.

dharizza’s picture

dharizza CreditAttribution: dharizza as a volunteer commented
FileSize
core_version_requirement-3139140-4.patch335 bytes

I downloaded this module and tried to apply this patch on version 8.x-1.x but it didn't applied cleanly, so I re-rolled the patch.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented

I would suggest merging this one into #3139135: Drupal 9 deprecated code report and close this one to save time for the maintainer.

And the scope of #3139135: Drupal 9 deprecated code report can cover this one, no need to rescope.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs review » Closed (duplicate)

Thanks, everyone for your efforts! Sorry that I am closing this as the patch here was merged into #3139135: Drupal 9 deprecated code report.