Problem/Motivation

Make compatible with Drupal 9.

Proposed resolution

Add core version requirement to be Drupal 8 and 9

Manual testing

Before:

Module is not installable without patch

After:

Module is installable with patch

Remaining tasks

Move the patch over to a merge request at gitlab.com/agaric/drupal/inotherwords

CommentFileSizeAuthor
#6 3139019-2-after.png41.58 KBmradcliffe
#5 3139109-2-after.png153.76 KBmradcliffe
#5 3139019-2-before.png60.53 KBmradcliffe
#2 add_core_version_requirement-3139019-2.patch342 bytesyonas.legesse

Comments

yonas.legesse created an issue. See original summary.

yonas.legesse’s picture

yonas.legesse commented
Status: Active » Needs review
StatusFileSize
new add_core_version_requirement-3139019-2.patch342 bytes

Added requirement in module info.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Drupal 9 porting weekend

Presuming this is for Drupal 9 porting weekend since this was created during that time.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

I'm reviewing the patch and manually testing it on drupal 9.0.x.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Issue summary: View changes
Status: Needs review » Needs work
StatusFileSize
new 3139019-2-before.png60.53 KB
new 3139109-2-after.png153.76 KB

The patch is simple and will work for now. Eventually the core: 8.x will need to be removed.

I tested the patch by cloning the module, installing the composer dependencies, revisiting the module installation page, installing the module.

However it looks like that Agaric would like code contributions to be done via gitlab.com/agaraic/drupal/inotherwords and not drupal.org :(

The next step, @yonas.legesse, if you're interested, is to fork their repository on gitlab.com, and make a merge request there of the changes you've done in this patch.

I'm going to mark this issue as Needs work based on that.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Issue summary: View changes
StatusFileSize
new 3139019-2-after.png41.58 KB

Whoops, renamed the wrong image on my desktop. Sorry.

yonas.legesse’s picture

yonas.legesse commented

@mradcliffe thank you for the info. I'll follow through.

yonas.legesse’s picture

yonas.legesse commented
Status: Needs work » Reviewed & tested by the community

The MR has been done so I'm changing the status as it has already been tested. Added core version requirement

mlncn’s picture

mlncn commented
Status: Reviewed & tested by the community » Fixed

Thanks so much for going above and beyond and making the change in the GitLab repo!

Merged and pushed over here a month ago but i hadn't gotten around to making a release, doing that now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.