Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Make compatible with Drupal 9.
Proposed resolution
Add core version requirement to be Drupal 8 and 9
Manual testing
Before:
After:
Remaining tasks
Move the patch over to a merge request at gitlab.com/agaric/drupal/inotherwords
Comment | File | Size | Author |
---|---|---|---|
#6 | 3139019-2-after.png | 41.58 KB | mradcliffe |
#5 | 3139019-2-before.png | 60.53 KB | mradcliffe |
#2 | add_core_version_requirement-3139019-2.patch | 342 bytes | yonas.legesse |
Comments
Comment #2
yonas.legesse CreditAttribution: yonas.legesse at Axelerant commentedAdded requirement in module info.
Comment #3
Kristen PolPresuming this is for Drupal 9 porting weekend since this was created during that time.
Comment #4
mradcliffeI'm reviewing the patch and manually testing it on drupal 9.0.x.
Comment #5
mradcliffeThe patch is simple and will work for now. Eventually the core: 8.x will need to be removed.
I tested the patch by cloning the module, installing the composer dependencies, revisiting the module installation page, installing the module.
However it looks like that Agaric would like code contributions to be done via gitlab.com/agaraic/drupal/inotherwords and not drupal.org :(
The next step, @yonas.legesse, if you're interested, is to fork their repository on gitlab.com, and make a merge request there of the changes you've done in this patch.
I'm going to mark this issue as Needs work based on that.
Comment #6
mradcliffeWhoops, renamed the wrong image on my desktop. Sorry.
Comment #7
yonas.legesse CreditAttribution: yonas.legesse at Axelerant commented@mradcliffe thank you for the info. I'll follow through.
Comment #8
yonas.legesse CreditAttribution: yonas.legesse at Axelerant commentedThe MR has been done so I'm changing the status as it has already been tested. Added core version requirement
Comment #9
mlncn CreditAttribution: mlncn at Agaric for Drutopia, Portside, Teachers with GUTS commentedThanks so much for going above and beyond and making the change in the GitLab repo!
Merged and pushed over here a month ago but i hadn't gotten around to making a release, doing that now.