15/15 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------------------------------------------------------------------------------------
  Line   comment_notify.inc
 ------ ----------------------------------------------------------------------------------------------------------------------------------
  25     Function comment_notify_add_notification not found while trying to analyse it - autoloading is probably not configured properly.
  37     Strict comparison using === between int and null will always evaluate to false.
  50     Strict comparison using === between int and null will always evaluate to false.
  67     Function comment_notify_remove_all_notifications not found while trying to analyse it - autoloading is probably not configured
         properly.
  84     Function comment_notify_update_notification not found while trying to analyse it - autoloading is probably not configured
         properly.
  87     Strict comparison using === between int and null will always evaluate to false.
  102    Function comment_notify_get_notification_type not found while trying to analyse it - autoloading is probably not configured
         properly.
  121    Function comment_notify_get_watchers not found while trying to analyse it - autoloading is probably not configured properly.
  128    Function comment_notify_get_watchers() should return array<Drupal\comment\CommentInterface> but returns
         array<Drupal\Core\Entity\EntityInterface>.
  140    Function comment_notify_mark_comment_as_notified not found while trying to analyse it - autoloading is probably not configured
         properly.
  142    Cannot access property $notified on int.
  149    Cannot call method id() on int.
  165    Function comment_notify_unsubscribe_by_email not found while trying to analyse it - autoloading is probably not configured
         properly.
  168    Cannot call method id() on object|true.
  198    Function comment_notify_unsubscribe_by_hash not found while trying to analyse it - autoloading is probably not configured
         properly.
 ------ ----------------------------------------------------------------------------------------------------------------------------------


 ------ ------------------------------------------------------------------------------------
  Line   comment_notify.module
 ------ ------------------------------------------------------------------------------------
  51     Call to an undefined method Drupal\Core\Form\FormInterface::getEntity().
  97     Call to an undefined method Drupal\Core\Form\FormInterface::getEntity().
  99     Function comment_notify_get_notification_type not found.
  140    Call to an undefined method Drupal\Core\Form\FormInterface::getEntity().
  161    Function comment_notify_get_notification_type not found.
  163    Function comment_notify_update_notification not found.
  175    Function comment_notify_add_notification not found.
  206    Function comment_notify_remove_all_notifications not found.
  233    Call to an undefined method Drupal\Core\Form\FormInterface::getEntity().
  303    Call to an undefined method Drupal\Core\Form\FormInterface::getEntity().
  402    Variable $comment_account in PHPDoc tag @var does not exist.
  403    Cannot call method getEmail() on object|true.
  425    Call to an undefined method Drupal\Core\Entity\ContentEntityInterface::getOwner().
  469    Function comment_notify_get_watchers not found.
  528    Function comment_notify_mark_comment_as_notified not found.
  572    If condition is always true.
 ------ ------------------------------------------------------------------------------------

 ------ --------------------------------------------------------
  Line   src/Controller/CommentNotifyController.php
 ------ --------------------------------------------------------
  23     Function comment_notify_unsubscribe_by_hash not found.
 ------ --------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------
  Line   src/Form/CommentNotifySettings.php
 ------ ---------------------------------------------------------------------------------------------
  104    Right side of && is always true.
  340    Call to an undefined method Drupal\Core\Entity\EntityInterface::getCommentedEntityTypeId().
  341    Call to an undefined method Drupal\Core\Entity\EntityInterface::getCommentedEntity().
  342    Call to an undefined method Drupal\Core\Entity\EntityInterface::getFieldName().
 ------ ---------------------------------------------------------------------------------------------


 ------ ---------------------------------------------------------------------------------------------------------------
  Line   src/UserNotificationSettings.php
 ------ ---------------------------------------------------------------------------------------------------------------
  35     Property Drupal\comment_notify\UserNotificationSettings::$userData (Drupal\user\UserData) does not accept
         Drupal\user\UserDataInterface.
  50     Variable $users in isset() is never defined.
  97     PHPDoc tag @param has invalid value ($setting
         Possible values: 'comment_notify', 'entity_notify'): Unexpected token "$setting", expected type at offset 76
  97     PHPDoc tag @param has invalid value ($uid): Unexpected token "$uid", expected type at offset 59
 ------ ---------------------------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------
  Line   tests/src/Functional/CommentNotifyAnonymousTest.php
 ------ ------------------------------------------------------------------
  63     Function comment_notify_get_notification_type not found.
  82     Function comment_notify_get_notification_type not found.
  108    Function comment_notify_get_notification_type not found.
  138    Function comment_notify_get_notification_type not found.
 ------ ------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------
  Line   tests/src/Functional/CommentNotifyNotificationsTest.php
 ------ ------------------------------------------------------------------------------------
  54     Variable $user_settings in PHPDoc tag @var does not exist.
  75     Call to method getPage() on an unknown class Behat\Mink\Session.
  76     Call to method getPage() on an unknown class Behat\Mink\Session.
  119    Method Drupal\Core\Entity\EntityBase::save() invoked with 1 parameter, 0 required.
  121    Function comment_notify_add_notification not found.
  139    Method Drupal\Core\Entity\EntityBase::save() invoked with 1 parameter, 0 required.
  141    Function comment_notify_add_notification not found.
 ------ ------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/CommentNotifyTestBase.php
 ------ ---------------------------------------------------------------------------------------------------------------
  92     Result of && is always true.
  135    Left side of && is always true.
 ------ ---------------------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------
  Line   tests/src/Kernel/CommentNotifyTokenReplaceTest.php
 ------ -----------------------------------------------------
  71     Function comment_notify_add_notification not found.
 ------ -----------------------------------------------------


Comments

shaktik created an issue. See original summary.

shaktik’s picture

Status: Active » Needs work
vaibhavjain’s picture

Issue tags: -Drupal 9 compatibility Drupal 9 porting weekend DIACWMay2020 +Drupal 9 compatibility, +Drupal 9 porting weekend, +DIACWMay2020
yonas.legesse’s picture

Assigned: Unassigned » yonas.legesse
yonas.legesse’s picture

Assigned: yonas.legesse » Unassigned
yonas.legesse’s picture

StatusFileSize
new1018 bytes

It seems that there is a pertinent problem when running drupal-check on a project basis. There's an elaborate issue on it available here: Autoloading is broken when added as a project dependency. For the moment, i've started going through the issues and applying fixes for functional ones. I've gone through the following in the patch:

  340    Call to an undefined method Drupal\Core\Entity\EntityInterface::getCommentedEntityTypeId().
  341    Call to an undefined method Drupal\Core\Entity\EntityInterface::getCommentedEntity().
  342    Call to an undefined method Drupal\Core\Entity\EntityInterface::getFieldName().
gnuget’s picture

Status: Needs work » Closed (duplicate)

Hi

Thanks for the patches, we already worked on the Drupal 9 support here:

So I guess we can mark this one as duplicated. :-)