Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Discovered at #2972224: Add .cspell.json to automate spellchecking in Drupal core
- inheritdic over \Drupal\Tests\views\Kernel\ViewsTemplateTest::$testViews
- inheritdodc over \Drupal\media_library\Form\AddFormBase::trustedCallbacks()
- inheritoc over \Drupal\Tests\help\Functional\ExperimentalHelpTest::setUp()
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3138731-3.8_y_x.patch | 1.48 KB | dww |
| #2 | 3138731-2.patch | 1.5 KB | jungle |
Comments
Comment #2
jungleComment #3
dwwBot can't possibly fail on doc-only comment fixes like this. Confirmed #2 applies cleanly to 9.y.x branches, and that there are no more instances of those variants on "inheritdoc" anywhere in the code.
Here's a backport to 8.9.x and 8.8.x branches (
git applydoesn't apply cleanly, butpatch -p1applies with fuzz).Super trivial "reroll", so I'm going to go ahead and RTBC even though I'm uploading a patch and I've lectured @jungle not to do this. ;)
Thanks!
-Derek
Comment #6
xjmCommitted #2 to 9.1.x and 9.0.x, and #3 to 8.9.x and 8.8.x. Thanks!
Comment #9
jungleGot committed in 3 hours! That's incredible! @dww, thanks for reviewing and your patch! :p @xjm, thanks for committing!
Comment #10
alexpottI think this should have been postponed on #2972224: Add .cspell.json to automate spellchecking in Drupal core. If we commit these then the wordlist needs to be updated on that patch and it'll never land. Plus we'll get to redo this issue when it lands because we have a chance of regressing.