Problem/Motivation

When adding a computed base field to the commerce_product_variation entity type, for example in order to use it as a Product Attribute field, \Drupal\commerce\CommerceEntityViewsData::getViewsData() errors out because computed fields don't have a schema.

Proposed resolution

Skip generating views data for computed fields.

Remaining tasks

Review.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

Release notes snippet

Nope.

CommentFileSizeAuthor
#6 3138565-commerce-2.x-2.19-do-not-commit.patch1.13 KBjsacksick
#3 3138565-commerce-2.x-2.17-do-not-commit.patch831 bytesamateescu
#2 3138565.patch885 bytesamateescu

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 3138565.patch885 bytes

Here's a patch for this.

amateescu’s picture

amateescu commented
StatusFileSize
new 3138565-commerce-2.x-2.17-do-not-commit.patch831 bytes

Also attaching a patch for the current stable Commerce release, so it can be used in projects that don't use the -dev version.

amateescu’s picture

amateescu commented
Related issues: +#3126828: Entity views fatal error on lingotek metadata field after upgrading from commerce 2.15 to 2.16
jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Your fix ls the appropriate one :), thanks, committed!

jsacksick’s picture

jsacksick commented
StatusFileSize
new 3138565-commerce-2.x-2.19-do-not-commit.patch1.13 KB

Attaching a patch that should apply to 2.19.

bradjones1’s picture

bradjones1
Primary language English
commented

FYI this issue is missing commit credit.

jsacksick’s picture

jsacksick commented

Not sure why, the commit author was properly set to Andrei.
https://git.drupalcode.org/project/commerce/-/commit/0efa05b162a6d54f526...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.