Hi. Thank you for great module.

I have request to make an option that disable source settings and turn off warning that appears when you don't have any library of fonts:
The Font Awesome library could not be found. Please verify Font Awesome is installed correctly or that the CDN has been activated and properly configured. Please see the admin page and the Font Awesome module README file for more details.

Some of us have installed templates that have bundled font awesome library and don't need include it again.

I would be appreciated. Thank you for your support.

CommentFileSizeAuthor
#6 optionally_load_assets-3138356-6.patch8.81 KBdaniel.moberly
#5 optionally_load_assets-3138356-5.patch8.9 KBdaniel.moberly
#4 optionally_load_assets-3138356-4.patch6.64 KBrromore

Comments

skinio created an issue. See original summary.

skinio’s picture

skinio commented

I figure it out that if I put spacebar in External File Location it will work. The External File Location field when it's empty it fills out with CDN.
The solution with spacebar is a little bit odd, but works for now (no additional libraries included and no warning).

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 8.x-2.16 » 8.x-2.x-dev
rromore’s picture

rromore commented
Status: Active » Needs review
StatusFileSize
new optionally_load_assets-3138356-4.patch6.64 KB

I need this functionality as I'm bundling the FontAwesome icons manually via my theme + webpack.

daniel.moberly’s picture

daniel.moberly commented
StatusFileSize
new optionally_load_assets-3138356-5.patch8.9 KB

This looks great, but this actually doesn't prevent the loading of the library - it just creates the settings to do so. Attaching a patch which:

  • Prevents loading the library when the setting is disabled
  • Provides additional information in the status report when the option is disabled
  • Updates the readme
daniel.moberly’s picture

daniel.moberly commented
StatusFileSize
new optionally_load_assets-3138356-6.patch8.81 KB

Changing the status report back to an error when the library is not installed and the load assets option is on

  • Daniel.Moberly committed 5cac6db on 8.x-2.x 
    Issue #3138356 by Daniel.Moberly, rromore: The icons source could be...
daniel.moberly’s picture

daniel.moberly commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

stijnhau’s picture

stijnhau commented

Installed the update and actualy this 'broke' the flow.
I propose we default the new added field to true so updates of the module don't suddenly stop including the css.
Cause now there was an issue importing the old db when updb didn't run for a strange reason.