web/modules/contrib/confi/config_import.drush.inc 169 Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.
web/modules/contrib/confi/config_import.drush.inc 169 Call to deprecated function file_unmanaged_save_data(). Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use Drupal\Core\File\FileSystemInterface::saveData().
web/modules/contrib/confi/src/ConfigImporterService.php 237 Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.

CommentFileSizeAuthor
#7 3138057-7.patch2.36 KBsophiavs
#5 3138057-5.patch996 bytessaphemmy
#2 3138057-2.patch1.84 KBmo_farhaz

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

mo_farhaz commented
Assigned: mo_farhaz » Unassigned
Status: Active » Needs review
StatusFileSize
new 3138057-2.patch1.84 KB

please review.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Needs work 
git apply 3138057-2.patch 
error: patch failed: config_import.drush.inc:166
error: config_import.drush.inc: patch does not apply
error: patch failed: src/ConfigImporterService.php:234
error: src/ConfigImporterService.php: patch does not apply
saphemmy’s picture

saphemmy commented
Assigned: Unassigned » saphemmy

I will work on this.

saphemmy’s picture

saphemmy commented
Assigned: saphemmy » Unassigned
StatusFileSize
new 3138057-5.patch996 bytes

The tests wouldn't run.
In my opinion, fix this before applying a patch because if you don't the tests will not pass on DRUPALCI.

PHP Fatal error:  Access level to Drupal\Tests\config_import\Unit\ConfigImporterServiceTestBase::expectException() must be public (as in class PHPUnit\Framework\TestCase) in /app/modules/contrib/confi/tests/src/Unit/ConfigImporterServiceTestBase.php on line 52

Fatal error: Access level to Drupal\Tests\config_import\Unit\ConfigImporterServiceTestBase::expectException() must be public (as in class PHPUnit\Framework\TestCase) in /app/modules/contrib/confi/tests/src/Unit/ConfigImporterServiceTestBase.php on line 52
sophiavs’s picture

sophiavs commented
Assigned: Unassigned » sophiavs

i'll work on those tests and try to apply the patch :)

sophiavs’s picture

sophiavs commented
StatusFileSize
new 3138057-7.patch2.36 KB

Still with error

sophiavs’s picture

sophiavs commented
Assigned: sophiavs » Unassigned

I'll have to stop with this issue, so i'm assigning to other person work on this

pflora’s picture

pflora commented

I've checked the souce code for the 8.x-1.x branch and the changes requested in this issue have already been made some time ago by a bot. If someone could verify that this is correct, I think this issue can be marked as fixed.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 8.x-1.x-dev » 3.0.x-dev
Status: Needs work » Fixed

This is done in 3.0.x branch
1.x branch is not anymore supported

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.