Problem/Motivation

As title

Proposed resolution

Remove redundant assertion messages at the same time.

Example:

-    $this->assertTrue(isset($ids['entity_test.entity_test.field_test_import']));
+    $this->assertArrayHasKey('entity_test.entity_test.field_test_import', $ids);

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 3138010-7.patch8.11 KBbeatrizrodrigues
#9 3138010-3.patch8.06 KBbeatrizrodrigues
#6 3138010-6.patch8.28 KBsuresh prabhu parkala
#2 simplenews-replace_isset_with_assertArrayHasKey-3138010-2.patch8.29 KBalexshipilov

Comments

alexshipilov created an issue. See original summary.

alexshipilov’s picture

alexshipilov commented
StatusFileSize
new simplenews-replace_isset_with_assertArrayHasKey-3138010-2.patch8.29 KB
alexshipilov’s picture

alexshipilov commented
Assigned: alexshipilov » Unassigned
Status: Active » Needs review
alexshipilov’s picture

alexshipilov commented
Version: 8.x-2.x-dev » 3.x-dev
adamps’s picture

adamps commented
Status: Needs review » Needs work

Seem like it no longer applies after I committed the other one.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 3138010-6.patch8.28 KB

Patch did not apply. Re-rolled patch please review.

adamps’s picture

adamps commented
Status: Needs review » Needs work

Patch did not succeed

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: Unassigned » beatrizrodrigues

I'm doing the reroll

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: beatrizrodrigues » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3138010-3.patch8.06 KB
beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: Unassigned » beatrizrodrigues
Status: Needs review » Needs work

I made a mistake, I'll do the reroll again

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
StatusFileSize
new 3138010-7.patch8.11 KB
beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: beatrizrodrigues » Unassigned
Status: Needs work » Needs review

adamps’s picture

adamps commented
Status: Needs review » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.