Problem/Motivation

Fox example:

-    $this->assertFalse(in_array('t3', $cids), "Existing key 3 has been removed from &\$cids");
-    $this->assertTrue(in_array('t4', $cids), "Non existing key 4 is still in &\$cids");
+    $this->assertNotContains('t3', $cids);
+    $this->assertContains('t4', $cids);

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 simplenews-replace_in_array_with_assertContains-3137976-5.patch3.92 KBalexshipilov
#2 simplenews-replace_in_array_with_assertContains-3137976-2.patch3.92 KBalexshipilov

Comments

alexshipilov created an issue. See original summary.

alexshipilov’s picture

alexshipilov commented
StatusFileSize
new simplenews-replace_in_array_with_assertContains-3137976-2.patch3.92 KB
alexshipilov’s picture

alexshipilov commented
Assigned: alexshipilov » Unassigned
Status: Active » Needs review
adamps’s picture

adamps commented
Version: 8.x-2.x-dev » 3.x-dev
Status: Needs review » Needs work

This and all the other similar ones need to be retested (and if needed rerolled) for the 3.x branch please.

alexshipilov’s picture

alexshipilov commented
Status: Needs work » Needs review
StatusFileSize
new simplenews-replace_in_array_with_assertContains-3137976-5.patch3.92 KB

rerolled, please review

  • AdamPS committed 5598b34 on 3.x authored by alexshipilov 
    Issue #3137976 by alexshipilov: Replace assertions involving calls to...
adamps’s picture

adamps commented
Status: Needs review » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.