Problem/Motivation

As title

Proposed resolution

Example:

-    $this->assertTrue(is_array($component));
+    $this->assertIsArray($component);

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 simplenews-replace_is_array_with_assertISArray-3137973-4.patch746 bytesalexshipilov
#2 simplenews-replace_is_array_with_assertISArray-3137973-2.patch746 bytesalexshipilov

Issue fork simplenews-3137973

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexshipilov created an issue. See original summary.

alexshipilov’s picture

alexshipilov commented
StatusFileSize
new simplenews-replace_is_array_with_assertISArray-3137973-2.patch746 bytes
alexshipilov’s picture

alexshipilov commented
Assigned: alexshipilov » Unassigned
Status: Active » Needs review
alexshipilov’s picture

alexshipilov commented
Version: 8.x-2.x-dev » 3.x-dev
StatusFileSize
new simplenews-replace_is_array_with_assertISArray-3137973-4.patch746 bytes
adamps’s picture

adamps commented

Lots of tiny patches is hard work for the maintainer!

davps made their first commit to this issue’s fork.

davps’s picture

davps commented
Version: 3.x-dev » 4.x-dev

davps opened merge request !84

davps’s picture

davps commented

@adamps, can you review this tiny fix and merge it so we can close the task already??

MR prepared.

  • adamps committed 9f6491e9 on 4.x authored by davps 
    Issue #3137973 by davps, alexshipilov: Replace assertions involving...
adamps’s picture

adamps commented
Status: Needs review » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.