Problem/Motivation

We have links in the footer with a class like "mailto". In that case, the specific .page__footer a:not([class]), .page__footer a.ext selector which adds the color definitions does not get applied because the link has a class and the "mailto" links get the general link color (blue in most cases).

Proposed resolution

Generalize link colors so that all links have the $footer-link-color applied. Make this change only for the footer and copyright region. Let's keep these selectors for the header for now.

CommentFileSizeAuthor
#2 3137671-generalize-link-color-in-footer.patch759 bytessasanikolic

Comments

sasanikolic created an issue. See original summary.

sasanikolic’s picture

sasanikolic commented
Status: Active » Needs review
StatusFileSize
new 3137671-generalize-link-color-in-footer.patch759 bytes

Here is the patch with the proposed solution. Don't think a code comment is needed as the code is self-explainatory.

sasanikolic’s picture

sasanikolic commented

Created a followup for link color definition in the footer: 3137672 - Improve color of links in footer.

pivica’s picture

pivica commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +next-release

Looks fine, thx. Let's test custom themes now.

  • pivica committed 46ee395 on 8.x-1.x authored by sasanikolic 
    Issue #3137671 by sasanikolic: Links in footer have default link colors...
pivica’s picture

pivica commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.