Problem
Fields of types which use a computed main property such as Geolocation can't be indexed.
This was working correctly with an older version of the module, but seems the helper that extracts the values has gone through some refactoring.

Solution
A small patch and a test.

CommentFileSizeAuthor
#5 fix_computed_fields_value_extraction_2.patch3.04 KBsimeonkesmev
#2 fix_computed_fields_value_extraction_1.patch3.7 KBsimeonkesmev
fix_computed_fields_value_extraction.patch3.71 KBsimeonkesmev

Comments

SimeonKesmev created an issue. See original summary.

simeonkesmev’s picture

simeonkesmev commented
StatusFileSize
new fix_computed_fields_value_extraction_1.patch3.7 KB
fuduley’s picture

fuduley commented

Patch from #2 works fine for me

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Component: General code » Framework
Priority: Major » Normal
Status: Needs review » Needs work

Thanks for reporting this problem!
Please provide a patch that applies, though, so I can test/reproduce.

Also, do you happen to know a version where this worked, to verify?

simeonkesmev’s picture

simeonkesmev commented
StatusFileSize
new fix_computed_fields_value_extraction_2.patch3.04 KB

Seems the actual issue was fixed by f1ea46415f27293a0e1737e57e29d51831630be3, as #3157397 seems to have been addressed first.
You can optionally just add the test, otherwise the ticket can be closed.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Fixed

Ah, good to hear. Thanks for reporting back!
And yes, the test looks great, thanks! (Also fails when reverting f1ea46415f, so that’s good, too.)
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.