As clear from screenshot and title.

CommentFileSizeAuthor
#12 Pasted_Image_6_15_20__3_21_PM.jpg285.66 KBjoshmiller
#9 commerce_fraud-order_status-3137543-9.patch2.8 KBvishalghyv
#6 commerce_fraud-order_status-3137543-6.patch2.26 KBvishalghyv
#4 OrderStatus_3137543_4.patch550 bytesvishalghyv
#3 ReflectingStatusChange_3137543_3.patch665 bytesvishalghyv
Screenshot (247).png100.52 KBvishalghyv
Screenshot (246).png144.01 KBvishalghyv

Comments

Vishalghyv created an issue. See original summary.

vishalghyv’s picture

vishalghyv commented
Priority: Normal » Major
vishalghyv’s picture

vishalghyv commented
Status: Active » Needs review
StatusFileSize
new ReflectingStatusChange_3137543_3.patch665 bytes

If One would want different status can change in Rule, But I thought there should be a default option to reflect

vishalghyv’s picture

vishalghyv commented
StatusFileSize
new OrderStatus_3137543_4.patch550 bytes
amjad1233’s picture

amjad1233
MJED
Location Brisbane
commented
Status: Needs review » Needs work

Is it possible to add some automated tests?

vishalghyv’s picture

vishalghyv commented
Status: Needs work » Needs review
StatusFileSize
new commerce_fraud-order_status-3137543-6.patch2.26 KB

Sure,
Will add UI test once tests in #3142694: Improving Tests for Commerce Fraud are commited,
Change from store admin to store customer allowed the test to pass

Status: Needs review » Needs work

The last submitted patch, 6: commerce_fraud-order_status-3137543-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vishalghyv’s picture

vishalghyv commented

Rule is not active in this is the reason for it failing

vishalghyv’s picture

vishalghyv commented
Status: Needs work » Needs review
StatusFileSize
new commerce_fraud-order_status-3137543-9.patch2.8 KB
derekcresswell’s picture

derekcresswell commented
Status: Needs review » Reviewed & tested by the community

Looks good.

  • joshmiller committed adba4d5 on 7.x-1.x authored by Vishalghyv 
    Issue #3137543 by Vishalghyv, amjad1233, DerekCresswell, joshmiller:...
joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new Pasted_Image_6_15_20__3_21_PM.jpg285.66 KB

Ok, so the patch works for newly installed modules. This doesn't effect any currently installed site, but it does provide a much less buggy first impression.

While committing, I cleaned up the "setup" function so it would enable the rule we wanted. This feels cleaner than the hook definition function call thing that was in the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.