Term reference elements showing term Id instead of label

Needed this for POC, so I hacked the term name visible. This patch will cause fatal error if Entity select webform_entity_select uses something else than Taxonomy term as type of item.

Used entityTypeManager so it should in theory work with any entity type. Tested with taxonomy terms and content (node) entities.

And the missing patch.

And the proper missing patch :)

@dsrdigialltd thanks for update!

+      if ($value_label != '') {

Should be written as

+      if ($value_label) {

Adding additional cases based on webform field type.
Let's see how it works for use cases.

Patches in #5 & #8 also failed for me.
Thanks Mohit, I can confirm your patch in #11 fixes my problem, I am using the Entity Select component.

Before

After

Re-rolled #11 patch with webform_entity_radios support.

Tested the patch and did not work as intended.

Returns no term fields.

I tested both #11 patch and #13 patch on a Drupal 10.2 clean installation with webforms version 6.2.
What I noticed is that if you choose webform_entity_checkboxes, webform_entity_select and/or webform_entity_radios (this last one is added in patch #13) the label of the terms are correctly displayed.

However if you choose webform_term_select the values are empty, nothing is displayed.
And if you choose for instance webform_term_checkboxes (this element is not added in the patches) the ID is displayed instead of the label.

What I notices while debugging is that webform_term_select skips this part of the code:

if (isset($value) && !empty($value)) {
            if (isset($this->getElements()[$component]['#target_type'])) {
              $target_type = $this->getElements()[$component]['#target_type'];
              $entity_storage = \Drupal::entityTypeManager()->getStorage($target_type);
              $entity = $entity_storage->load($value);
              if (is_object($entity)) {
                $value_label = $entity->label();
              }
            }
          }

Here is a new patch that also adds labels for Term select and Term checkbox elements.

Here is a new patch rerolled after the PHPCS fixes

It works proper